Prepare wmde.9 (1.37) (#357)

* Use 1.35.7 for wmde.7

* Remove newline at end of wmde.7 env file

* Update WDQS_FRONTEND_COMMIT_HASH

This includes mostly bumps of packages and a few minor fixes
to things. Nothing users need to worry about in terms of an upgrade,
but useful (probably) for them to have)

* Bump commits for some other released things...

* Add docs for security releasing (that I used)

* Add sec-release docs to index

* wdqs-ui 69ec53f45fdaf7119a3e4bd2845adbcffe24a515

* Start wmde.8

* Start wmde.9 which would be 1.37

* Add CHANGES.md for 1.37 rel

* Update CI test versions

* Update versions again

* Poke less wdqs-gui deps

* Use fixed wdqs package-lock.json

* Update test/upgrade env files for new tests

* Add more details to CHANGES.md

* Remove more old-versions tests

* Add error reporting to client part of repo_client test

This is already in the repo settings file, but missing from
client.
This will make debugging easier...

* Output MediaWiki logs in CI too

* Define entitySources for client test

* Disable fed props tests for now

* Revert "Output MediaWiki logs in CI too"

This reverts commit 2c62a55.

* Disable fedprops tests in more places

* Revert "Revert "Output MediaWiki logs in CI too""

This reverts commit 650f78a.

* More general path for mwlog output

* Revert "More general path for mwlog output"

This reverts commit 7f739d1.

* Revert "Revert "Revert "Output MediaWiki logs in CI too"""

This reverts commit a6091a0.

* Add wgWBClientSettings['itemAndPropertySourceName']

* Try outputting mw logs again

* Poke the logging again...

* mwlog, more ls output, and no /

* mwlogs, continue on error & cleaner ls output

* debug logging of mw in tests

* Use assert.strictEqual in tests

* Fix test: entityschema.js

* Use assert package consistently

* Try mw-content-text for edit page content

It looks like some things have changed around a bit
in core, and the old body id that was used now returns more text.
mw-content-text is another element within that old body that
removes some of this text (mainly links)

Extra text was Jump to navigation\nJump to search\n\n
before the actual page content.

* Use 1.37.6

* mariadb:10.9

* $ is webdriver, not jqeury /o\

* Use assert.deepStrictEqual

* Poke interwiki name and source name

* Update WikibaseLocalMedia

This includes ProfessionalWiki/WikibaseLocalMedia#18

* 1.0.2 of WikibaseLocalMedia

* Delete already disabled feddy props tests for now

* Change CHANGES to trigger rebuild

Author: addshore

.github/workflows/built_and_test.yml

@@ -16,7 +16,7 @@ on:
       - 'README.md'
 
 env:
-  env_file: ${{ github.event.inputs.env_file || 'versions/wmde8.env' }}
+  env_file: ${{ github.event.inputs.env_file || 'versions/wmde9.env' }}
 
 jobs:
 
@@ -446,10 +446,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        databaseImageName: [ 'mariadb:10.3' ] # 'mysql:5.6' disabled https://phabricator.wikimedia.org/T296066
+        databaseImageName: [ 'mariadb:10.9' ] # 'mysql:5.6' disabled https://phabricator.wikimedia.org/T296066
         suite: [ 
           repo, 
-          fedprops, 
           repo_client, 
           quickstatements, 
           pingback, 
@@ -459,7 +458,6 @@ jobs:
           base__repo,
           base__repo_client,
           base__pingback,
-          base__fedprops,
         ]
     needs:
       - build_wikibase_bundle
@@ -494,6 +492,13 @@ jobs:
         if: always()
         run: test/docker_logs.sh
 
+      - name: mediawiki logs
+        if: always()
+        continue-on-error: true
+        run: |
+          ls -lahr test/mwlog test/mwlog/*
+          tail -n +1 test/mwlog/*/*.log
+
       - name: Archive docker test artifacts
         uses: actions/upload-artifact@v3
         if: always()
@@ -507,14 +512,10 @@ jobs:
       fail-fast: false
       matrix:
         version: [
-          '1.32-base',
-          '1.33-base',
-          '1.34-base',
-          '1.35-base',
-          'wmde.0',
-          'wmde.1',
-          'wmde.2',
-          'wmde.3'
+          # Latest 1.35
+          'wmde.7',
+          # Latest 1.36
+          'wmde.8',
         ]
     needs:
       - build_wikibase
@@ -550,9 +551,10 @@ jobs:
       fail-fast: false
       matrix:
         version: [
-          'wmde.1-bundle',
-          'wmde.2-bundle',
-          'wmde.3-bundle',
+          # Latest 1.35
+          'wmde.7-bundle',
+          # Latest 1.36
+          'wmde.8-bundle',
         ]
     needs:
       - build_wikibase_bundle

.github/workflows/test.yml

@@ -17,10 +17,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        databaseImageName: [ 'mariadb:10.3' ] # 'mysql:5.6' disabled https://phabricator.wikimedia.org/T296066
+        databaseImageName: [ 'mariadb:10.9' ] # 'mysql:5.6' disabled https://phabricator.wikimedia.org/T296066
         suite: [
           repo,
-          fedprops,
           repo_client,
           quickstatements,
           pingback,
@@ -30,7 +29,6 @@ jobs:
           base__repo,
           base__repo_client,
           base__pingback,
-          base__fedprops,
         ]
     runs-on: ubuntu-latest
     timeout-minutes: 30

CHANGES.md

@@ -4,6 +4,19 @@ This file is only intended to serve the developers of this repository and of the
 
 This provides an overview of the releases that have been made using this release pipeline.
 
+## IN DEVELOPMENT October 2022: First 1.37 release
+
+The [standard MediaWiki upgrade process](https://www.mediawiki.org/wiki/Manual:Upgrading) can be followed for this release.
+
+- [MediaWiki release notes](https://www.mediawiki.org/wiki/Release_notes/1.37)
+- [Wikibase release notes](https://github.com/wikimedia/Wikibase/blob/REL1_37/RELEASE-NOTES-1.37)
+
+The Query service was also updated from `0.3.97` to `0.3.115`, but no additional upgrade process is needed.
+
+| Suite Version | Version Info | Date availbile | Run number | Release task  |
+|---------------|----------------------|----------------|------------| --------------|
+| wmde.9 ([spec](https://github.com/wmde/wikibase-release-pipeline/blob/wmde.9/versions/wmde9.env),[metadata](https://github.com/wmde/wikibase-release-pipeline/blob/main/versions/wmde9)) | MediaWiki (1.37.6, PHP 7.4.30), WDQS (0.3.115)    | TODO | [TODO](https://github.com/wmde/wikibase-release-pipeline/actions/runs/TODO) | [T317890](https://phabricator.wikimedia.org/T317890) |
+
 ## September 2022: Security releases
 
 | Suite Version | MediaWiki release | Date availbile | Run number | Release task  |

Docker/build/WDQS-frontend/Dockerfile

@@ -17,9 +17,7 @@ RUN apk --no-cache add --virtual build-dependencies ca-certificates git jq make
 
 # TODO do npm build instead of leaving any dev node modules hanging around
 RUN mv package.json package.json.orig \
-    && jq 'delpaths([["devDependencies","karma-qunit"],["devDependencies","qunitjs"],["devDependencies","sinon"]])' \
-        > package.json < package.json.orig \
-    && jq 'setpath(["devDependencies","less"]; "~2.7.1")' \
+    && jq 'delpaths([["devDependencies","karma-qunit"],["devDependencies","sinon"]])' \
         > package.json < package.json.orig \
     && npm install \
     && npm run build

Docker/build/Wikibase/LocalSettings.php.REL1_35.template

@@ -21,6 +21,7 @@ ${DOLLAR}wgDebugLogGroups = array(
 	'resourceloader' => '/var/log/mediawiki/resourceloader.log',
 	'exception' => '/var/log/mediawiki/exception.log',
 	'error' => '/var/log/mediawiki/error.log',
+	'fatal' => '/var/log/mediawiki/fatal.log',
 );
 
 ## Site Settings

Docker/build/Wikibase/LocalSettings.php.template

@@ -21,6 +21,7 @@ ${DOLLAR}wgDebugLogGroups = array(
 	'resourceloader' => '/var/log/mediawiki/resourceloader.log',
 	'exception' => '/var/log/mediawiki/exception.log',
 	'error' => '/var/log/mediawiki/error.log',
+	'fatal' => '/var/log/mediawiki/fatal.log',
 );
 
 ## Site Settings

Docker/test/selenium/README.md

@@ -63,7 +63,7 @@ The behavior of the tests can be modified with several environment variables.
 When working on the browser tests,
 you’ll want to consult the documentation of the following libraries we use:
 
-* [WebdriverIO](http://webdriver.io/api.html) for controlling the browser
+* [WebdriverIO](https://webdriver.io/docs/api) for controlling the browser
   (`browser`, `$`, `waitForVisible`, …)
 * [Mocha](https://mochajs.org/) as the general testing framework
   (`describe`, `it`, `before`, …)

Docker/test/selenium/helpers/default-functions.js

@@ -133,8 +133,8 @@ const defaultFunctions = function () {
 
 		browser.pause( 2 * 1000 );
 
-		$( '#bodyContent' ).waitForDisplayed();
-		return $( '#bodyContent' ).getText();
+		$( '#mw-content-text' ).waitForDisplayed();
+		return $( '#mw-content-text' ).getText();
 	} );
 
 	/**
@@ -150,7 +150,7 @@ const defaultFunctions = function () {
 		const changes = result.data.query.recentchanges;
 		const foundResult = _.find( changes, expectedChange );
 
-		assert( result.status === 200 );
+		assert.strictEqual( result.status, 200 );
 
 		if ( !foundResult ) {
 			console.error( 'Could not find:' );

Docker/test/selenium/specs/confirm_edit/confirm-edit.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { assert } = require( 'console' );
+const assert = require( 'assert' );
 
 describe( 'ConfirmEdit', function () {
 
@@ -13,7 +13,7 @@ describe( 'ConfirmEdit', function () {
 			'paris'
 		);
 
-		assert( executionResult === 'something great' );
+		assert.strictEqual( executionResult, 'something great' );
 
 	} );
 

Docker/test/selenium/specs/elasticsearch/elasticsearch.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const { assert } = require( 'console' );
+const assert = require( 'assert' );
 const Util = require( 'wdio-mediawiki/Util' );
 const WikibaseApi = require( 'wdio-wikibase/wikibase.api' );
 
@@ -37,7 +37,7 @@ describe( 'ElasticSearch', function () {
 		// alias should be visible on item page
 		$( '.wikibase-aliasesview-list-item' ).waitForDisplayed();
 		const alias = $( '.wikibase-aliasesview-list-item' ).getText();
-		assert( alias === itemAlias );
+		assert.strictEqual( alias, itemAlias );
 	} );
 
 	it( 'should be able to search case-insensitive', async function () {