ci-operator: Remove uneccessary ARTIFACT_DIR touches

This got pulled up into the 'env' block for
cluster-launch-installer-e2e.yaml and
cluster-launch-installer-src.yaml in 43dde9e (Set KUBE_SSH_BASTION
and KUBE_SSH_KEY_PATH in installer tests, 2018-12-23, openshift#2469).  That
obsoleted the previous export in the src template's test script.

I'm also removing a number of existing e2e consumers that set this to
the default value, since there's no need to do that.

Author: wking

ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-master.yaml

@@ -39,7 +39,7 @@ tests:
     upgrade: false
 - artifact_dir: /tmp/artifacts
   as: e2e-aws-operator
-  commands: ARTIFACT_DIR=/tmp/artifacts JUNIT_REPORT=1 make test-e2e
+  commands: JUNIT_REPORT=1 make test-e2e
   openshift_installer_src:
     cluster_profile: aws
 - as: e2e-aws-image-registry

ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.0.yaml

@@ -39,7 +39,7 @@ tests:
     upgrade: false
 - artifact_dir: /tmp/artifacts
   as: e2e-aws-operator
-  commands: ARTIFACT_DIR=/tmp/artifacts JUNIT_REPORT=1 make test-e2e
+  commands: JUNIT_REPORT=1 make test-e2e
   openshift_installer_src:
     cluster_profile: aws
 - as: e2e-aws-image-registry

ci-operator/config/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.1.yaml

@@ -40,7 +40,7 @@ tests:
     upgrade: false
 - artifact_dir: /tmp/artifacts
   as: e2e-aws-operator
-  commands: ARTIFACT_DIR=/tmp/artifacts JUNIT_REPORT=1 make test-e2e
+  commands: JUNIT_REPORT=1 make test-e2e
   openshift_installer_src:
     cluster_profile: aws
 - as: e2e-aws-image-registry

ci-operator/jobs/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-master-presubmits.yaml

@@ -147,7 +147,7 @@ presubmits:
         - name: JOB_NAME_SAFE
           value: e2e-aws-operator
         - name: TEST_COMMAND
-          value: ARTIFACT_DIR=/tmp/artifacts JUNIT_REPORT=1 make test-e2e
+          value: JUNIT_REPORT=1 make test-e2e
         image: ci-operator:latest
         imagePullPolicy: Always
         name: ""

ci-operator/jobs/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.0-presubmits.yaml

@@ -147,7 +147,7 @@ presubmits:
         - name: JOB_NAME_SAFE
           value: e2e-aws-operator
         - name: TEST_COMMAND
-          value: ARTIFACT_DIR=/tmp/artifacts JUNIT_REPORT=1 make test-e2e
+          value: JUNIT_REPORT=1 make test-e2e
         image: ci-operator:latest
         imagePullPolicy: Always
         name: ""

ci-operator/jobs/openshift/cluster-image-registry-operator/openshift-cluster-image-registry-operator-release-4.1-presubmits.yaml

@@ -147,7 +147,7 @@ presubmits:
         - name: JOB_NAME_SAFE
           value: e2e-aws-operator
         - name: TEST_COMMAND
-          value: ARTIFACT_DIR=/tmp/artifacts JUNIT_REPORT=1 make test-e2e
+          value: JUNIT_REPORT=1 make test-e2e
         image: ci-operator:latest
         imagePullPolicy: Always
         name: ""

ci-operator/templates/openshift/openshift-ansible/cluster-launch-src.yaml

@@ -127,7 +127,6 @@ objects:
 
         # don't let clients impact the global kubeconfig
         cp /tmp/shared/admin.kubeconfig /tmp/admin.kubeconfig
-        export ARTIFACT_DIR=/tmp/artifacts
 
         # set up cloud-provider-specific env vars
         if [[ "${CLUSTER_TYPE}" == "gcp" ]]; then