cmd/openshift-install/create: Replace Routes().List with Get

We know the name we're looking for, so a Get should be slightly more
efficient.  The list landed with the route logic in ff53523 (add
logs at end of install for kubeadmin, consoleURL, 2018-12-06, openshift#806)
without clear motivation.  It's possible that the intention was
shielding from the console operator renaming their route, with the:

  Route found in openshift-console namespace: ...

lines pointing us at the renamed route.  But it seems unlikely that
any such renaming would happen, and if it does, we expect the
console-operator change to fail its end-to-end testing with the
installer not finding a route with the old name.

Author: wking

cmd/openshift-install/create.go

@@ -440,20 +440,15 @@ func waitForConsole(ctx context.Context, config *rest.Config) (string, error) {
 	silenceRemaining := logDownsample
 	timer.StartTimer("Console")
 	wait.Until(func() {
-		consoleRoutes, err := rc.RouteV1().Routes(consoleNamespace).List(ctx, metav1.ListOptions{})
-		if err == nil && len(consoleRoutes.Items) > 0 {
-			for _, route := range consoleRoutes.Items {
-				logrus.Debugf("Route found in openshift-console namespace: %s", route.Name)
-				if route.Name == consoleRouteName {
-					if uri, _, err2 := routeapihelpers.IngressURI(&route, ""); err2 == nil {
-						url = uri.String()
-						logrus.Debug("OpenShift console route is admitted")
-						cancel()
-					} else {
-						err = err2
-					}
-					break
-				}
+		route, err := rc.RouteV1().Routes(consoleNamespace).Get(ctx, consoleRouteName, metav1.GetOptions{})
+		if err == nil {
+			logrus.Debugf("Route found in openshift-console namespace: %s", consoleRouteName)
+			if uri, _, err2 := routeapihelpers.IngressURI(route, ""); err2 == nil {
+				url = uri.String()
+				logrus.Debug("OpenShift console route is admitted")
+				cancel()
+			} else {
+				err = err2
 			}
 		}
 		if err != nil {
@@ -462,12 +457,6 @@ func waitForConsole(ctx context.Context, config *rest.Config) (string, error) {
 				logrus.Debugf("Still waiting for the console route: %v", err)
 				silenceRemaining = logDownsample
 			}
-		} else if len(consoleRoutes.Items) == 0 {
-			silenceRemaining--
-			if silenceRemaining == 0 {
-				logrus.Debug("Still waiting for the console route...")
-				silenceRemaining = logDownsample
-			}
 		}
 	}, 2*time.Second, consoleRouteContext.Done())
 	err = consoleRouteContext.Err()