Adds closedby to dialog interface (#12728)

argyleink · delucis · web-flow · commit ee66a45b2507 · 2024-12-13T10:40:23.000Z
* Adds `closedby` to dialog interface Standards status https://chromestatus.com/feature/5097714453577728 * Add changeset --------- Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
diff --git a/.changeset/neat-pumas-accept.md b/.changeset/neat-pumas-accept.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Adds type support for the `closedby` attribute for `<dialog>` elements
diff --git a/packages/astro/astro-jsx.d.ts b/packages/astro/astro-jsx.d.ts
@@ -679,6 +679,7 @@ declare namespace astroHTML.JSX {
 
 	interface DialogHTMLAttributes extends HTMLAttributes {
 		open?: boolean | string | undefined | null;
+		closedby?: 'none' | 'closerequest' | 'any' | undefined | null;
 	}
 
 	interface EmbedHTMLAttributes extends HTMLAttributes {

Original file line number	Diff line number	Diff line change
`@@ -679,6 +679,7 @@ declare namespace astroHTML.JSX {`
`679`	`679`
`680`	`680`	`interface DialogHTMLAttributes extends HTMLAttributes {`
`681`	`681`	`open?: boolean \| string \| undefined \| null;`
	`682`	`+ closedby?: 'none' \| 'closerequest' \| 'any' \| undefined \| null;`
`682`	`683`	`}`
`683`	`684`
`684`	`685`	`interface EmbedHTMLAttributes extends HTMLAttributes {`