fix: Unexpected token < in JSON at position 1 (#8827)

Rishi Raj Jain · web-flow · commit ce3025cfa27a · 2023-10-16T11:55:27.000+01:00
diff --git a/.changeset/great-eyes-rest.md b/.changeset/great-eyes-rest.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+better error handling there whenever we don't get a normal 200 response
diff --git a/packages/astro/src/cli/add/index.ts b/packages/astro/src/cli/add/index.ts
@@ -725,10 +725,10 @@ async function fetchPackageJson(
 	const packageName = `${scope ? `${scope}/` : ''}${name}`;
 	const registry = await getRegistry();
 	const res = await fetch(`${registry}/${packageName}/${tag}`);
-	if (res.status === 404) {
-		return new Error();
-	} else {
+	if (res.status >= 200 && res.status < 300) {
 		return await res.json();
+	} else {
+		return new Error();
 	}
 }
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'astro': patch
 +---
++
 +better error handling there whenever we don't get a normal 200 response
Original file line number	Diff line number	Diff line change
`@@ -725,10 +725,10 @@ async function fetchPackageJson(`
`725`	`725`	const packageName = `${scope ? `${scope}/` : ''}${name}`;
`726`	`726`	`const registry = await getRegistry();`
`727`	`727`	const res = await fetch(`${registry}/${packageName}/${tag}`);
`728`		`- if (res.status === 404) {`
`729`		`- return new Error();`
`730`		`- } else {`
	`728`	`+ if (res.status >= 200 && res.status < 300) {`
`731`	`729`	`return await res.json();`
	`730`	`+ } else {`
	`731`	`+ return new Error();`
`732`	`732`	`}`
`733`	`733`	`}`
`734`	`734`