runfix(backup): prevent exporting undefined self user id [WPB-17558] (#19124)

* fix(backup): prevent exporting undefined self user id [WPB-17558]

* address conversations without other participants

* refactor participating users logic

Author: V-Gira

src/script/backup/CrossPlatformBackup/CPB.export.ts

@@ -156,7 +156,10 @@ export const exportCPBHistoryFromDatabase = async ({
       }
 
       const conversationId = new BackupQualifiedId(qualified_conversation.id, qualified_conversation.domain ?? '');
-      const senderUserId = new BackupQualifiedId(qualified_from?.id ?? from ?? '', qualified_from?.domain ?? '');
+      const senderUserId = new BackupQualifiedId(
+        qualified_from?.id ?? from ?? user.id,
+        qualified_from?.domain ?? user.domain,
+      );
       const senderClientId = from_client_id ?? '';
       const creationDate = new BackupDateTime(new Date(time));
       // for debugging purposes
@@ -178,7 +181,7 @@ export const exportCPBHistoryFromDatabase = async ({
         const asset = new BackupMessageContent.Asset(
           assetParseData.content_type,
           Number.parseInt(`${assetParseData.content_length}`),
-          assetParseData.info.name,
+          assetParseData.info?.name ?? '',
           transformObjectToArray(assetParseData.otr_key),
           transformObjectToArray(assetParseData.sha256),
           assetParseData.key,

src/script/backup/CrossPlatformBackup/data.schema.ts

@@ -32,7 +32,7 @@ export type ConversationTableEntry = zod.infer<typeof ConversationTableEntrySche
 export const UserTableEntrySchema = zod.object({
   handle: zod.string().optional(),
   id: zod.string(),
-  name: zod.string().optional(),
+  name: zod.string().optional().nullable(),
   qualified_id: QualifiedIdSchema.optional(),
 });
 export type UserTableEntry = zod.infer<typeof UserTableEntrySchema>;
@@ -41,7 +41,7 @@ export const EventTableEntrySchema = zod.object({
   category: zod.number().int().optional(),
   conversation: zod.string().min(1, 'Conversation is required'),
   data: zod.any(),
-  from: zod.string().optional(),
+  from: zod.string().optional().nullable(),
   from_client_id: zod.string().optional(),
   id: zod.string().optional(),
   primary_key: zod.number().int().positive('Primary key must be a positive integer'),

src/script/conversation/ConversationMapper.ts

@@ -30,6 +30,7 @@ import {
   ADD_PERMISSION,
   CONVERSATION_CELLS_STATE,
 } from '@wireapp/api-client/lib/conversation';
+import {QualifiedId} from '@wireapp/api-client/lib/user';
 import ko from 'knockout';
 import {isObject} from 'underscore';
 
@@ -292,11 +293,25 @@ export class ConversationMapper {
     }
 
     // Active participants from database or backend payload
-    const participatingUserIds =
-      qualified_others ||
-      (members?.others
-        ? members.others.map(other => ({domain: other.qualified_id?.domain || '', id: other.id}))
-        : others.map(userId => ({domain: '', id: userId})));
+    let participatingUserIds: QualifiedId[] = [];
+
+    if (qualified_others) {
+      participatingUserIds = qualified_others;
+    }
+
+    if (!qualified_others && members?.others?.length) {
+      participatingUserIds = members.others.map(other => ({
+        domain: other.qualified_id?.domain ?? '',
+        id: other.id,
+      }));
+    }
+
+    if (!qualified_others && !members?.others?.length && others) {
+      participatingUserIds = others.map(userId => ({
+        domain: '',
+        id: userId,
+      }));
+    }
 
     conversationEntity.participating_user_ids(participatingUserIds);