feat: activate mls for client via mls feature config [FS-1088] (#13898)

* feat: always pass mlsconfig object to initialize mlsclient

* feat: enable sending external proposals when mls feature flag is off

* runfix: add support for broken clients by disabling mls for them

* refactor: update var name

* chore: bump core to use renamed systemCrypto

* chore: use exact version match

* chore: update lock file

* refactor: rename disabling mls helper boolean

* refactor: simplify supportmls logic

* runfix: require feature flag to support mls for m4

* runfix: make supportMLS a function

* Revert "runfix: make supportMLS a function"

This reverts commit 06ba72d.

* Revert "runfix: require feature flag to support mls for m4"

This reverts commit a32154e.

* runfix: add mls feature config var back to supportMLS helper

Author: PatrykBuniX

src/script/main/app.ts

@@ -31,7 +31,7 @@ import {Runtime} from '@wireapp/commons';
 
 import {getLogger, Logger} from 'Util/Logger';
 import {t} from 'Util/LocalizerUtil';
-import {arrayToBase64, checkIndexedDb, createRandomUuid} from 'Util/util';
+import {arrayToBase64, checkIndexedDb, createRandomUuid, supportsMLS} from 'Util/util';
 import {TIME_IN_MILLIS} from 'Util/TimeUtil';
 import {enableLogging} from 'Util/LoggerUtil';
 import {Environment} from 'Util/Environment';
@@ -428,7 +428,7 @@ class App {
 
       const conversationEntities = await conversationRepository.getConversations();
 
-      if (Config.getConfig().FEATURE.ENABLE_MLS) {
+      if (supportsMLS()) {
         // We send external proposal to all the MLS conversations that are in an unknown state (not established nor pendingWelcome)
         await mlsConversationState.getState().sendExternalToPendingJoin(
           conversationEntities,

src/script/service/CoreSingleton.ts

@@ -22,7 +22,7 @@ import {ClientType} from '@wireapp/api-client/src/client/';
 import {container, singleton} from 'tsyringe';
 import {APIClient} from './APIClientSingleton';
 import {createStorageEngine, DatabaseTypes} from './StoreEngineProvider';
-import {isTemporaryClientAndNonPersistent} from 'Util/util';
+import {isTemporaryClientAndNonPersistent, supportsMLS} from 'Util/util';
 import {Config} from '../Config';
 
 declare global {
@@ -45,15 +45,15 @@ export class Core extends Account<Uint8Array> {
 
         return createStorageEngine(storeName, dbType);
       },
-      mlsConfig: Config.getConfig().FEATURE.ENABLE_MLS
+      mlsConfig: supportsMLS()
         ? {
             coreCrypoWasmFilePath: '/min/core-crypto.wasm',
+            keyingMaterialUpdateThreshold: Config.getConfig().FEATURE.MLS_CONFIG_KEYING_MATERIAL_UPDATE_THRESHOLD,
             /*
-             * When in an electron context, the window.secretsCrypto will be populated by the renderer process.
+             * When in an electron context, the window.systemCrypto will be populated by the renderer process.
              * We then give those crypto primitives to the core that will use them when encrypting MLS secrets.
-             * When in an browser context, then this secretsCrypto will be undefined and the core will then use it's internal encryption system
+             * When in a browser context, then this systemCrypto will be undefined and the core will then use it's internal encryption system
              */
-            keyingMaterialUpdateThreshold: Config.getConfig().FEATURE.MLS_CONFIG_KEYING_MATERIAL_UPDATE_THRESHOLD,
             systemCrypto: window.systemCrypto,
           }
         : undefined,

src/script/util/util.ts

@@ -398,3 +398,7 @@ export const getSelectionPosition = (element: HTMLTextAreaElement, currentMentio
 
   return {newEnd, newStart};
 };
+
+// temporary hack that disables mls for old 'broken' desktop clients, see https://github.com/wireapp/wire-desktop/pull/6094
+export const supportsMLS = () =>
+  Config.getConfig().FEATURE.ENABLE_MLS && (!Runtime.isDesktopApp() || window.systemCrypto);