Skip to content

Commit b5c394e

Browse files
committed
Comment cleanup; fix lint failure in packages/jest-cli/src/SearchSource.js
1 parent ea7935f commit b5c394e

File tree

3 files changed

+12
-9
lines changed

3 files changed

+12
-9
lines changed

.azure-pipelines-steps.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
#
2-
# CI build and test steps. See azure-pipelines.yml for job details.
2+
# Steps for building and testing Jest. See jobs defined in .azure-pipelines.yml
33
#
44

5+
# Clones the repo
56
steps:
67
- checkout: self
78

@@ -17,7 +18,7 @@ steps:
1718
versionSpec: '2.7'
1819
displayName: 'Use Python 2.7'
1920

20-
# Workaround to move repo source files into a "jest" folder (see azure-pipelines.yml for details)
21+
# Workaround to move source files under a "jest" folder (see .azure-pipelines.yml for details)
2122
- script: |
2223
cd /
2324
mv $(Build.Repository.LocalPath) $(JEST_DIR)

.azure-pipelines.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#
2-
# Azure Pipelines CI configuration for Linux, Windows, and macOS.
2+
# Azure Pipelines configuration for building and testing Jest on Linux, Windows, and macOS.
33
#
44

55
jobs:
@@ -23,14 +23,18 @@ jobs:
2323
pool:
2424
vmImage: macos-10.13
2525
steps:
26+
# This step can be removed once Mercurial gets installed on the macOS image. See https://github.com/Microsoft/azure-pipelines-image-generation/issues/604
2627
- script: HOMEBREW_NO_AUTO_UPDATE=1 brew install mercurial
2728
displayName: 'Install Mercurial'
2829
- template: .azure-pipelines-steps.yml
2930

3031
variables:
31-
# Ensures output produced by Jest for certain tests includes ANSI escape characters (needed to match snapshots)
32+
# Used by chalk. Ensures output from Jest includes ANSI escape characters that are needed to match test snapshots.
3233
FORCE_COLOR: 1
33-
# Default checkout directory is "s", but inline snapshot tests will fail due to assumption that Jest is running under a "jest" folder
34-
# (see packages/jest-message-util/src/index.js PATH_JEST_PACKAGES)
34+
35+
# By default, Azure Pipelines clones to an "s" directory, which causes tests to fail due to assumption of Jest being run from a "jest" directory.
36+
# See packages/jest-message-util/src/index.js PATH_JEST_PACKAGES for more details.
3537
JEST_DIR: $(Agent.BuildDirectory)/jest
38+
39+
# Ensures the handful of tests that should be skipped during CI are
3640
CI: true

packages/jest-cli/src/SearchSource.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,7 @@ export default class SearchSource {
200200
): SearchResult {
201201
if (Array.isArray(paths) && paths.length) {
202202
const cwd = realpath(process.cwd());
203-
const resolvedPaths = paths.map(p =>
204-
path.resolve(cwd, p),
205-
);
203+
const resolvedPaths = paths.map(p => path.resolve(cwd, p));
206204
return this.findRelatedTests(new Set(resolvedPaths), collectCoverage);
207205
}
208206
return {tests: []};

0 commit comments

Comments
 (0)