Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea: use with pyramid_authstack #53

Open
tripsolutions opened this issue Mar 2, 2021 · 0 comments
Open

idea: use with pyramid_authstack #53

tripsolutions opened this issue Mar 2, 2021 · 0 comments

Comments

@tripsolutions
Copy link

We're using a slightly modified version of pyramid_jwt as part of a stack defined using https://github.com/wichert/pyramid_authstack and I'm trying to create a minimal pull request for the functionality.

My question is, would it be acceptable to have the functions set_jwt_cookie_authentication_policy and set_jwt_authentication_policy also return the created policies so that we can register them in pyramid_authstack?

From what I can see calling get_claims (via registered property jwt_claims) or create_token (via registered method create_jwt_token) on a request that did not match the jwt policy should not be a problem, so the only issue that my PR should address is how to obtain the policy so it can be added to the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants