chore: add the new parameter to all engines and add tests

Author: furqaankhan

common/src/main/java/org/apache/sedona/common/Functions.java

@@ -1804,7 +1804,7 @@ private static Geometry[] convertGeometryToArray(Geometry geom) {
     return array;
   }
 
-  public static Geometry generatePoints(Geometry geom, int numPoints, int seed) {
+  public static Geometry generatePoints(Geometry geom, int numPoints, long seed) {
     RandomPointsBuilderSeed pointsBuilder = new RandomPointsBuilderSeed(geom.getFactory(), seed);
     pointsBuilder.setExtent(geom);
     pointsBuilder.setNumPoints(numPoints);

flink/src/main/java/org/apache/sedona/flink/expressions/Functions.java

@@ -1557,6 +1557,15 @@ public Geometry eval(
       Geometry geom = (Geometry) o;
       return org.apache.sedona.common.Functions.generatePoints(geom, numPoints);
     }
+
+    @DataTypeHint(value = "RAW", bridgedTo = org.locationtech.jts.geom.Geometry.class)
+    public Geometry eval(
+        @DataTypeHint(value = "RAW", bridgedTo = org.locationtech.jts.geom.Geometry.class) Object o,
+        @DataTypeHint(value = "Integer") Integer numPoints,
+        @DataTypeHint(value = "BIGINT") Long seed) {
+      Geometry geom = (Geometry) o;
+      return org.apache.sedona.common.Functions.generatePoints(geom, numPoints, seed);
+    }
   }
 
   public static class ST_NRings extends ScalarFunction {

flink/src/test/java/org/apache/sedona/flink/FunctionTest.java

@@ -2146,7 +2146,7 @@ public void testIsPolygonCW() {
   public void testGeneratePoints() {
     Table polyTable =
         tableEnv.sqlQuery(
-            "SELECT ST_Buffer(ST_GeomFromWKT('LINESTRING(50 50,150 150,150 50)'), 10, false, 'endcap=round join=round') AS geom");
+            "SELECT ST_Buffer(ST_GeomFromWKT('LINESTRING(50 50,10 10,10 50)'), 10, false, 'endcap=round join=round') AS geom");
     Geometry actual =
         (Geometry)
             first(
@@ -2155,6 +2155,24 @@ public void testGeneratePoints() {
                 .getField(0);
     assertEquals(actual.getNumGeometries(), 15);
 
+    actual =
+        (Geometry)
+            first(
+                    polyTable
+                        .select(
+                            call(
+                                Functions.ST_GeneratePoints.class.getSimpleName(),
+                                $("geom"),
+                                5,
+                                100L))
+                        .as("geom")
+                        .select(
+                            call(Functions.ST_ReducePrecision.class.getSimpleName(), $("geom"), 5)))
+                .getField(0);
+    String expected =
+        "MULTIPOINT ((40.02957 46.70645), (37.11646 37.38582), (14.2051 29.23363), (40.82533 31.47273), (28.16839 34.16338))";
+    assertEquals(expected, actual.toString());
+
     polyTable =
         tableEnv.sqlQuery(
             "SELECT ST_GeomFromWKT('MULTIPOLYGON (((10 0, 10 10, 20 10, 20 0, 10 0)), ((50 0, 50 10, 70 10, 70 0, 50 0)))') AS geom");

python/tests/sql/test_function.py

@@ -1611,6 +1611,12 @@ def test_generate_points(self):
         .first()[0]
         assert actual == 15
 
+        actual = self.spark.sql(
+            "SELECT ST_AsText(ST_ReducePrecision(ST_GeneratePoints(ST_GeomFromWKT('MULTIPOLYGON (((10 0, 10 10, 20 10, 20 0, 10 0)), ((50 0, 50 10, 70 10, 70 0, 50 0)))'), 5, 10), 5))") \
+            .first()[0]
+        expected = "MULTIPOINT ((53.82582 2.57803), (13.55212 2.44117), (59.12854 3.70611), (61.37698 7.14985), (10.49657 4.40622))"
+        assert expected == actual
+
         actual = self.spark.sql(
             "SELECT ST_NumGeometries(ST_GeneratePoints(ST_Buffer(ST_GeomFromWKT('LINESTRING(50 50,150 150,150 50)'), 10, false, 'endcap=round join=round'), 15, 100))") \
             .first()[0]

snowflake-tester/src/test/java/org/apache/sedona/snowflake/snowsql/TestFunctions.java

@@ -401,6 +401,9 @@ public void test_ST_GeneratePoints() {
     verifySqlSingleRes(
         "select sedona.ST_NumGeometries(sedona.ST_GeneratePoints(sedona.ST_GeomFromWKT('POLYGON ((1 0, 1 1, 2 1, 2 0, 1 0))'), 15))",
         15);
+    verifySqlSingleRes(
+        "select sedona.ST_NumGeometries(sedona.ST_GeneratePoints(sedona.ST_GeomFromWKT('POLYGON ((1 0, 1 1, 2 1, 2 0, 1 0))'), 15, 100))",
+        15);
   }
 
   @Test

snowflake-tester/src/test/java/org/apache/sedona/snowflake/snowsql/TestFunctionsV2.java

@@ -383,6 +383,9 @@ public void test_ST_GeneratePoints() {
     verifySqlSingleRes(
         "select sedona.ST_NumGeometries(sedona.ST_GeneratePoints(ST_GeomFromWKT('POLYGON ((1 0, 1 1, 2 1, 2 0, 1 0))'), 15))",
         15);
+    verifySqlSingleRes(
+        "select sedona.ST_NumGeometries(sedona.ST_GeneratePoints(ST_GeomFromWKT('POLYGON ((1 0, 1 1, 2 1, 2 0, 1 0))'), 15, 100))",
+        15);
   }
 
   @Test

snowflake/src/main/java/org/apache/sedona/snowflake/snowsql/UDFs.java

@@ -372,6 +372,12 @@ public static byte[] ST_GeneratePoints(byte[] geometry, int numPoints) {
         Functions.generatePoints(GeometrySerde.deserialize(geometry), numPoints));
   }
 
+  @UDFAnnotations.ParamMeta(argNames = {"geometry", "numPoints", "seed"})
+  public static byte[] ST_GeneratePoints(byte[] geometry, int numPoints, long seed) {
+    return GeometrySerde.serialize(
+        Functions.generatePoints(GeometrySerde.deserialize(geometry), numPoints, seed));
+  }
+
   @UDFAnnotations.ParamMeta(argNames = {"geometry", "precision"})
   public static String ST_GeoHash(byte[] geometry, int precision) {
     return Functions.geohash(GeometrySerde.deserialize(geometry), precision);

snowflake/src/main/java/org/apache/sedona/snowflake/snowsql/UDFsV2.java

@@ -518,6 +518,15 @@ public static String ST_GeneratePoints(String geometry, int numPoints) {
         Functions.generatePoints(GeometrySerde.deserGeoJson(geometry), numPoints));
   }
 
+  @UDFAnnotations.ParamMeta(
+      argNames = {"geometry", "numPoints", "seed"},
+      argTypes = {"Geometry", "int", "long"},
+      returnTypes = "Geometry")
+  public static String ST_GeneratePoints(String geometry, int numPoints, long seed) {
+    return GeometrySerde.serGeoJson(
+        Functions.generatePoints(GeometrySerde.deserGeoJson(geometry), numPoints, seed));
+  }
+
   @UDFAnnotations.ParamMeta(
       argNames = {"geometry", "precision"},
       argTypes = {"Geometry", "int"})