Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHATWG - Policies Button Color Inconsistency in Navbar #458

Closed
realamanvats opened this issue Apr 1, 2025 · 1 comment · Fixed by #459
Closed

WHATWG - Policies Button Color Inconsistency in Navbar #458

realamanvats opened this issue Apr 1, 2025 · 1 comment · Fixed by #459

Comments

@realamanvats
Copy link

What is the issue with the HTML Standard?

Description:
I noticed an inconsistency in the navigation bar regarding the Policies button. When clicking on any button in the navbar, the background color changes from green to white. However, the Policies button remains green even after being clicked, which disrupts the UI consistency.

Steps to Reproduce:
Open the web page.

Click on any button in the navbar.

Observe that the clicked button changes its background color from green to white.

Click on the Policies button and notice that its background color does not change—it remains green.

Expected Behavior:
The Policies button should behave consistently with the other navbar buttons, changing its background color to white after being clicked.

Actual Behavior:
The Policies button remains green even after being clicked, unlike the other buttons.

Suggested Fix:
Ensure that the Policies button follows the same styling rules as other navbar buttons. This may involve checking CSS or JavaScript event handling related to button state changes.

Additional Information:
Browser: (Mention the browser where you tested this issue)

Image

normal working button bg color change

Image

@annevk annevk transferred this issue from whatwg/html Apr 1, 2025
@annevk
Copy link
Member

annevk commented Apr 1, 2025

Nice find!

This shouldn't be too hard to fix. We need to change https://github.com/whatwg/whatwg.org/blob/main/site-template.html to make this link part of the template. And then fill it in appropriately as part of https://github.com/whatwg/whatwg.org/blob/main/convert_policy.py, perhaps branching on title.

annevk added a commit that referenced this issue Apr 4, 2025
@annevk annevk closed this as completed in 417c00b Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants