Skip to content

Commit cfaf3fa

Browse files
noxannevk
authored andcommitted
Fix #129: error in replace algorithm
1 parent 7b5e052 commit cfaf3fa

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

dom.bs

+8-7
Original file line numberDiff line numberDiff line change
@@ -1599,15 +1599,16 @@ steps:
15991599
<li>Let <var>removedNodes</var> be the empty list.
16001600

16011601
<li>
1602-
<p>If <var>child</var>'s parent is not null, set <var>removedNodes</var> to a list solely
1603-
containing <var>child</var> and remove <var>child</var> from its <var>parent</var> with the
1604-
<i>suppress observers flag</i> set.
1602+
<p>If <var>child</var>'s <a>parent</a> is not null, run these substeps:
16051603

1606-
<p class="note no-backref">The above can only be false if <var>child</var> is <var>node</var>.
1604+
<ol>
1605+
<li><p>Set <var>removedNodes</var> to a list solely containing <var>child</var>.
16071606

1608-
<li><a>Remove</a> <var>child</var>
1609-
from its <var>parent</var> with the
1610-
<i>suppress observers flag</i> set.
1607+
<li><p><a>Remove</a> <var>child</var> from its <var>parent</var> with the
1608+
<i>suppress obvservers flag</i> set.
1609+
</ol>
1610+
1611+
<p class="note no-backref">The above can only be false if <var>child</var> is <var>node</var>.
16111612

16121613
<li>Let <var>nodes</var> be <var>node</var>'s <a>children</a> if <var>node</var> is a
16131614
{{DocumentFragment}} <a>node</a>, and a list containing solely <var>node</var> otherwise.

dom.html

+8-4
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
<div class="head">
7070
<p data-fill-with="logo"><a class="logo" href="https://whatwg.org/"> <img alt="WHATWG" height="100" src="https://resources.whatwg.org/logo-dom.svg"> </a> </p>
7171
<h1 class="p-name no-ref allcaps" id="title">DOM</h1>
72-
<h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="content">Living Standard — Last Updated <time class="dt-updated" datetime="2015-12-15">15 December 2015</time></span></h2>
72+
<h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="content">Living Standard — Last Updated <time class="dt-updated" datetime="2015-12-17">17 December 2015</time></span></h2>
7373
<div data-fill-with="spec-metadata">
7474
<dl>
7575
<dt>Participate:
@@ -985,10 +985,14 @@ <h4 class="heading settled" data-level="4.2.1" id="mutation-algorithms"><span cl
985985
<li><a data-link-type="dfn" href="#concept-node-adopt">Adopt</a> <var>node</var> into <var>parent</var>’s <a data-link-type="dfn" href="#concept-node-document">node document</a>.
986986
<li>Let <var>removedNodes</var> be the empty list.
987987
<li>
988-
<p>If <var>child</var>’s parent is not null, set <var>removedNodes</var> to a list solely
989-
containing <var>child</var> and remove <var>child</var> from its <var>parent</var> with the <i>suppress observers flag</i> set. </p>
988+
<p>If <var>child</var>’s <a data-link-type="dfn" href="#concept-tree-parent">parent</a> is not null, run these substeps: </p>
989+
<ol>
990+
<li>
991+
<p>Set <var>removedNodes</var> to a list solely containing <var>child</var>. </p>
992+
<li>
993+
<p><a data-link-type="dfn" href="#concept-node-remove">Remove</a> <var>child</var> from its <var>parent</var> with the <i>suppress obvservers flag</i> set. </p>
994+
</ol>
990995
<p class="note no-backref" role="note">The above can only be false if <var>child</var> is <var>node</var>. </p>
991-
<li><a data-link-type="dfn" href="#concept-node-remove">Remove</a> <var>child</var> from its <var>parent</var> with the <i>suppress observers flag</i> set.
992996
<li>Let <var>nodes</var> be <var>node</var>’s <a data-link-type="dfn" href="#concept-tree-child">children</a> if <var>node</var> is a <code class="idl"><a data-link-type="idl" href="#documentfragment">DocumentFragment</a></code> <a data-link-type="dfn" href="#concept-node">node</a>, and a list containing solely <var>node</var> otherwise.
993997
<li><a data-link-type="dfn" href="#concept-node-insert">Insert</a> <var>node</var> into <var>parent</var> before <var>reference child</var> with
994998
the <i>suppress observers flag</i> set.

0 commit comments

Comments
 (0)