fix: obs sas token validation

Author: assafgi

README.md

@@ -468,7 +468,7 @@ proxy_url = VALUE
 | <a name="input_function_app_storage_account_prefix"></a> [function\_app\_storage\_account\_prefix](#input\_function\_app\_storage\_account\_prefix) | Weka storage account name prefix | `string` | `"weka"` | no |
 | <a name="input_function_app_subnet_delegation_cidr"></a> [function\_app\_subnet\_delegation\_cidr](#input\_function\_app\_subnet\_delegation\_cidr) | Subnet delegation enables you to designate a specific subnet for an Azure PaaS service. | `string` | `"10.0.1.0/25"` | no |
 | <a name="input_function_app_subnet_delegation_id"></a> [function\_app\_subnet\_delegation\_id](#input\_function\_app\_subnet\_delegation\_id) | Required to specify if subnet\_name were used to specify pre-defined subnets for weka. Function subnet delegation requires an additional subnet, and in the case of pre-defined networking this one also should be pre-defined | `string` | `""` | no |
-| <a name="input_function_app_version"></a> [function\_app\_version](#input\_function\_app\_version) | Function app code version (hash) | `string` | `"875b29685e79d1d332c01d02e42eb6ed"` | no |
+| <a name="input_function_app_version"></a> [function\_app\_version](#input\_function\_app\_version) | Function app code version (hash) | `string` | `"0b29f922e1f847a5ca6055cc55ec4c24"` | no |
 | <a name="input_get_weka_io_token"></a> [get\_weka\_io\_token](#input\_get\_weka\_io\_token) | The token to download the Weka release from get.weka.io. | `string` | `""` | no |
 | <a name="input_hotspare"></a> [hotspare](#input\_hotspare) | Number of hotspares to set on weka cluster. Refer to https://docs.weka.io/weka-system-overview/ssd-capacity-management#hot-spare | `number` | `1` | no |
 | <a name="input_install_cluster_dpdk"></a> [install\_cluster\_dpdk](#input\_install\_cluster\_dpdk) | Install weka cluster with DPDK | `bool` | `true` | no |

function-app/code/functions/clusterize/clusterize.go

@@ -85,10 +85,6 @@ func PrepareWekaObs(ctx context.Context, p *ClusterizationParams) (err error) {
 
 	noExistingObs := p.Obs.AccessKey == ""
 
-	if noExistingObs && p.Obs.Name != "" {
-		return fmt.Errorf("OBS misconfiguration: access key must be provided when creating a new OBS")
-	}
-
 	if p.Obs.NetworkAccess == "Disabled" && noExistingObs && !p.CreateBlobPrivateEndpoint {
 		return fmt.Errorf("private endpoint creation is required for obs when public access is disabled")
 	}

functions.tf

@@ -343,6 +343,11 @@ resource "azurerm_linux_function_app" "function_app" {
       condition     = var.install_weka_url != "" || var.weka_version != ""
       error_message = "Please provide either 'install_weka_url' or 'weka_version' variables."
     }
+
+    precondition {
+      condition     = !var.tiering_enable_obs_integration || var.tiering_obs_name == "" || var.tiering_blob_obs_access_key != ""
+      error_message = "OBS misconfiguration: access key must be provided when tiering_obs_name is set"
+    }
   }
 
   depends_on = [module.network, module.iam, azurerm_storage_account.deployment_sa, azurerm_private_endpoint.file_endpoint, azurerm_private_endpoint.blob_endpoint]

variables.tf

@@ -410,7 +410,7 @@ variable "function_app_storage_account_container_prefix" {
 variable "function_app_version" {
   type        = string
   description = "Function app code version (hash)"
-  default     = "875b29685e79d1d332c01d02e42eb6ed"
+  default     = "0b29f922e1f847a5ca6055cc55ec4c24"
 }
 
 variable "function_app_dist" {