Fix(perMessageDeflate): Don't close stream after flush.

- Based on the previous fix, we close the stream when maxPayload is reached, now we do not need to close it on flush.
- Merged tests

Author: Amirali-Amirifar

lib/permessage-deflate.js

@@ -366,7 +366,9 @@ class PerMessageDeflate {
       const err = this._inflate[kError];
 
       if (err) {
-        this._inflate.close();
+        //
+        // The stream was already closed in `inflateOnData()`.
+        //
         this._inflate = null;
         callback(err);
         return;
@@ -494,7 +496,7 @@ function inflateOnData(chunk) {
   this[kError].code = 'WS_ERR_UNSUPPORTED_MESSAGE_LENGTH';
   this[kError][kStatusCode] = 1009;
   this.removeListener('data', inflateOnData);
-  this.close()
+  this.close();
 }
 
 /**

test/permessage-deflate.test.js

@@ -592,24 +592,7 @@ describe('PerMessageDeflate', () => {
 
     it("doesn't call the callback twice when `maxPayload` is exceeded", (done) => {
       const perMessageDeflate = new PerMessageDeflate({}, false, 25);
-      const buf = Buffer.from('A'.repeat(50))
-
-      perMessageDeflate.accept([{}]);
-      perMessageDeflate.compress(buf, true, (err, data) => {
-        if (err) return done(err);
-
-        perMessageDeflate.decompress(data, true, (err) => {
-          assert.ok(err instanceof RangeError);
-          assert.strictEqual(err.message, 'Max payload size exceeded');
-          done();
-        });
-      });
-    });
-
-
-    it("returns correct error code on large payloads exceeding `maxPayload`", (done) => {
-      const perMessageDeflate = new PerMessageDeflate({}, false,  1e6);
-      const buf = Buffer.from('A'.repeat(2**29-24));
+      const buf = Buffer.from('A'.repeat(1024 * 1024));
 
       perMessageDeflate.accept([{}]);
       perMessageDeflate.compress(buf, true, (err, data) => {