Skip to content

Commit 072fcc0

Browse files
committed
test: reenable Firefox stable testing
fixes webrtcHacks#1136
1 parent 54ab59d commit 072fcc0

File tree

3 files changed

+4
-24
lines changed

3 files changed

+4
-24
lines changed

.github/workflows/e2e-tests.yaml

+4-2
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ jobs:
77
runs-on: ubuntu-latest
88
strategy:
99
matrix:
10-
browser: [chrome]
11-
version: [stable, beta, dev]
10+
browser: [chrome, firefox]
11+
version: [stable, beta]
1212
include:
13+
- browser: chrome
14+
version: dev
1315
- browser: firefox
1416
version: nightly
1517
steps:

test/karma.conf.js

-22
Original file line numberDiff line numberDiff line change
@@ -11,29 +11,7 @@
1111
const os = require('os');
1212
const puppeteerBrowsers = require('@puppeteer/browsers');
1313

14-
async function determineFirefoxVersion(version) {
15-
const rawVersions = await fetch('https://product-details.mozilla.org/1.0/firefox_versions.json');
16-
const versions = await rawVersions.json();
17-
return versions.FIREFOX_NIGHTLY;
18-
// TODO: support stable, beta, nightly, esr.
19-
// This has issues with the assumptions browsers makes about download urls
20-
// (or Firefox about directory structure and where it includes the platform)
21-
// This base url coems close:
22-
// 'https://archive.mozilla.org/pub/firefox/releases/' + buildId + '/' + platform + '/en-US/';
23-
}
24-
2514
async function download(browser, version, cacheDir, platform) {
26-
if (browser === 'firefox') {
27-
// TODO: see above, resolve stable, beta, nightly, esr
28-
const buildId = await determineFirefoxVersion(version);
29-
await puppeteerBrowsers.install({
30-
browser,
31-
buildId,
32-
cacheDir,
33-
platform,
34-
});
35-
return buildId;
36-
}
3715
const buildId = await puppeteerBrowsers
3816
.resolveBuildId(browser, platform, version);
3917
await puppeteerBrowsers.install({

0 commit comments

Comments
 (0)