2.3.14 release (#437)

- update to wabac.js 2.23.4 to make hashing optional, not require wasm
- add tests with CSP policy in place

Author: ikreymer

CHANGES.md

@@ -2,9 +2,13 @@
 
 ## CHANGES
 
+v2.3.14
+- Loading: Make hash check optional, don't requires wasm to load (via wabac.js 2.23.4)
+
 v2.3.13
 - Loading: Fix regression in loading s3:// URLs
 - Rewrite: Fix rewrite of HLS when only available bandwidth exceeds max (via wabac.js 2.23.3)
+- Loading: Fix for AppImage
 
 v2.3.12
 

package.json

@@ -22,7 +22,7 @@
   "dependencies": {
     "@fortawesome/fontawesome-free": "^5.15.4",
     "@shoelace-style/shoelace": "~2.15.1",
-    "@webrecorder/wabac": "^2.23.3",
+    "@webrecorder/wabac": "^2.23.4",
     "bulma": "^0.9.3",
     "electron-log": "^4.4.1",
     "electron-updater": "^6.6.2",
@@ -60,7 +60,6 @@
     "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-lit": "^1.11.0",
     "eslint-plugin-wc": "^2.0.4",
-    "http-server": "^13.0.2",
     "husky": "^8.0.0",
     "lint-staged": "^14.0.0",
     "mini-css-extract-plugin": "^2.3.0",
@@ -69,6 +68,7 @@
     "raw-loader": "^4.0.2",
     "sass-embedded": "^1.70.0",
     "sass-loader": "^13.3.2",
+    "serve": "^14.2.4",
     "style-loader": "^3.2.1",
     "ts-lit-plugin": "^2.0.0-pre.1",
     "ts-loader": "^9.4.4",
@@ -94,13 +94,14 @@
     "build": "webpack --mode production && ./adblock/fetch-adblock.sh",
     "build-dev": "webpack --mode development",
     "build-docs": "yarn run build && cd mkdocs && ./copy-site.sh && mkdocs build",
-    "start-prod": "http-server -p 9990 --cors",
-    "start-docs-prod": "yarn run build-docs && cd mkdocs/_genhtml && http-server -p 9990 --cors",
+    "start-prod": "serve -l 9990 --cors",
+    "start-docs-prod": "yarn run build-docs && cd mkdocs/_genhtml && serve -l 9990 --cors",
     "start-dev": "webpack serve --mode development",
     "start-docs": "yarn run build-dev && cd mkdocs && ./copy-site.sh && mkdocs serve",
     "start-electron": "NODE_ENV=development electron ./dist/electron.js $1",
-    "test-start-embed": "cp tests/embed/iframe-test.html mkdocs/_genhtml/; cd tests/embed; http-server -p 8020",
-    "test-start-sandbox": "cd tests/embed/sandbox; http-server -p 8030",
+    "test-start-prod": "yarn run build-docs; cp tests/embed/test-serve.json mkdocs/_genhtml/serve.json; cd mkdocs/_genhtml; serve -l 9990 --cors",
+    "test-start-embed": "cp tests/embed/iframe-test.html mkdocs/_genhtml/; cd tests/embed; serve -l 8020",
+    "test-start-sandbox": "cd tests/embed/sandbox; serve -l 8030",
     "update-ruffle": "./ruffle/download-latest-ruffle.sh",
     "pack": "CSC_IDENTITY_AUTO_DISCOVERY=false electron-builder --publish never",
     "pack-signed": "electron-builder",

playwright.config.js

@@ -19,7 +19,7 @@ export default defineConfig({
   ],
   webServer: [
     {
-      command: "yarn run start-docs-prod",
+      command: "yarn run test-start-prod",
       url: "http://127.0.0.1:9990",
       timeout: 120 * 1000,
       reuseExistingServer: !process.env.CI,

tests/embed/test-serve.json

@@ -0,0 +1,10 @@
+{
+  "cleanUrls": false,
+  "headers": [{
+    "source": "*",
+    "headers": [{
+      "key": "Content-Security-Policy",
+      "value": "default-src 'self' 'unsafe-inline' data: blob:"
+    }]
+  }]
+}

tests/embeds.spec.js

@@ -1,6 +1,12 @@
 import { test, expect } from "@playwright/test";
 
 test("same-domain embed is loading", async ({ page }) => {
+  page.on("response", async (response) => {
+    if (response.url() === "http://localhost:9990/embed.html") {
+      expect(await response.headerValue("Content-Security-Policy")).toBe("default-src 'self' 'unsafe-inline' data: blob:");
+    }
+  });
+
   await page.goto("http://localhost:9990/embed.html");
 
   const res = page
@@ -15,7 +21,7 @@ test("same-domain embed is loading", async ({ page }) => {
 });
 
 test("docs page embed is loading", async ({ page }) => {
-  await page.goto("http://localhost:9990/docs/embedding/");
+  await page.goto("http://localhost:9990/docs/embedding/index.html");
 
   const res = page
     .locator("replay-web-page")