refactor: types (#625)

Author: alexander-akait

package-lock.json

@@ -95,7 +95,7 @@
     "prettier": "^2.8.7",
     "standard-version": "^9.3.1",
     "typescript": "^4.9.5",
-    "uglify-js": "^3.18.0",
+    "uglify-js": "^3.19.3",
     "webpack": "^5.92.1",
     "webpack-cli": "^4.10.0",
     "worker-loader": "^3.0.8"

package.json

@@ -98,7 +98,7 @@ const { minify } = require("./minify");
  * @param {SourceMapInput | undefined} sourceMap
  * @param {MinimizerOptions<T>} minifyOptions
  * @param {ExtractCommentsOptions | undefined} extractComments
- * @returns {Promise<MinimizedResult>}
+ * @returns {Promise<MinimizedResult> | MinimizedResult}
  */
 
 /**
@@ -124,7 +124,7 @@ const { minify } = require("./minify");
 
 /**
  * @template T
- * @typedef {JestWorker & { transform: (options: string) => MinimizedResult, minify: (options: InternalOptions<T>) => MinimizedResult }} MinimizerWorker
+ * @typedef {JestWorker & { transform: (options: string) => Promise<MinimizedResult>, minify: (options: InternalOptions<T>) => Promise<MinimizedResult> }} MinimizerWorker
  */
 
 /**

src/index.js

@@ -81,9 +81,9 @@ function throttleAll(limit, tasks) {
 /* istanbul ignore next */
 /**
  * @param {Input} input
- * @param {SourceMapInput | undefined} sourceMap
- * @param {CustomOptions} minimizerOptions
- * @param {ExtractCommentsOptions | undefined} extractComments
+ * @param {SourceMapInput} [sourceMap]
+ * @param {CustomOptions} [minimizerOptions]
+ * @param {ExtractCommentsOptions} [extractComments]
  * @return {Promise<MinimizedResult>}
  */
 async function terserMinify(
@@ -334,9 +334,9 @@ terserMinify.supportsWorkerThreads = () => true;
 /* istanbul ignore next */
 /**
  * @param {Input} input
- * @param {SourceMapInput | undefined} sourceMap
- * @param {CustomOptions} minimizerOptions
- * @param {ExtractCommentsOptions | undefined} extractComments
+ * @param {SourceMapInput} [sourceMap]
+ * @param {CustomOptions} [minimizerOptions]
+ * @param {ExtractCommentsOptions} [extractComments]
  * @return {Promise<MinimizedResult>}
  */
 async function uglifyJsMinify(
@@ -468,10 +468,15 @@ async function uglifyJsMinify(
    * @returns {import("uglify-js").MinifyOptions & { sourceMap: undefined } & { output: import("uglify-js").OutputOptions & { beautify: boolean }}}
    */
   const buildUglifyJsOptions = (uglifyJsOptions = {}) => {
-    // eslint-disable-next-line no-param-reassign
-    delete minimizerOptions.ecma;
-    // eslint-disable-next-line no-param-reassign
-    delete minimizerOptions.module;
+    if (typeof uglifyJsOptions.ecma !== "undefined") {
+      // eslint-disable-next-line no-param-reassign
+      delete uglifyJsOptions.ecma;
+    }
+
+    if (typeof uglifyJsOptions.module !== "undefined") {
+      // eslint-disable-next-line no-param-reassign
+      delete uglifyJsOptions.module;
+    }
 
     // Need deep copy objects to avoid https://github.com/terser/terser/issues/366
     return {
@@ -557,8 +562,8 @@ uglifyJsMinify.supportsWorkerThreads = () => true;
 /* istanbul ignore next */
 /**
  * @param {Input} input
- * @param {SourceMapInput | undefined} sourceMap
- * @param {CustomOptions} minimizerOptions
+ * @param {SourceMapInput} [sourceMap]
+ * @param {CustomOptions} [minimizerOptions]
  * @return {Promise<MinimizedResult>}
  */
 async function swcMinify(input, sourceMap, minimizerOptions) {
@@ -663,8 +668,8 @@ swcMinify.supportsWorkerThreads = () => false;
 /* istanbul ignore next */
 /**
  * @param {Input} input
- * @param {SourceMapInput | undefined} sourceMap
- * @param {CustomOptions} minimizerOptions
+ * @param {SourceMapInput} [sourceMap]
+ * @param {CustomOptions} [minimizerOptions]
  * @return {Promise<MinimizedResult>}
  */
 async function esbuildMinify(input, sourceMap, minimizerOptions) {