Pass output to the logger factory (#156)

theofidry · web-flow · commit ee7a38d49f0c · 2022-10-22T08:52:25.000Z
diff --git a/src/ParallelCommand.php b/src/ParallelCommand.php
@@ -94,7 +94,7 @@ final protected function execute(InputInterface $input, OutputInterface $output)
                 Closure::fromCallable([$this, 'getItemName']),
                 $commandName,
                 $this->getDefinition(),
-                $this->createErrorHandler(),
+                $this->createErrorHandler($output),
             )
             ->build()
             ->execute(
@@ -128,7 +128,7 @@ protected function getParallelExecutableFactory(
         );
     }
 
-    protected function createErrorHandler(): ErrorHandler
+    protected function createErrorHandler(OutputInterface $output): ErrorHandler
     {
         return new LoggingErrorHandler(
             new ThrowableCodeErrorHandler(
diff --git a/src/Parallelization.php b/src/Parallelization.php
@@ -135,7 +135,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
                 fn (int $count) => $this->getItemName($count),
                 $this->getName(),
                 $this->getDefinition(),
-                $this->createErrorHandler(),
+                $this->createErrorHandler($output),
             )
             ->build()
             ->execute(
@@ -265,8 +265,7 @@ protected function getParallelExecutableFactory(
             ->withRunAfterBatch(Closure::fromCallable([$this, 'runAfterBatch']));
     }
 
-    // TODO: probably worth passing the output here in case
-    protected function createErrorHandler(): ErrorHandler
+    protected function createErrorHandler(OutputInterface $output): ErrorHandler
     {
         $errorHandler = new ThrowableCodeErrorHandler(
             ResetServiceErrorHandler::forContainer($this->getContainer()),

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ final protected function execute(InputInterface $input, OutputInterface $output)`
`94`	`94`	`Closure::fromCallable([$this, 'getItemName']),`
`95`	`95`	`$commandName,`
`96`	`96`	`$this->getDefinition(),`
`97`		`- $this->createErrorHandler(),`
	`97`	`+ $this->createErrorHandler($output),`
`98`	`98`	`)`
`99`	`99`	`->build()`
`100`	`100`	`->execute(`
`@@ -128,7 +128,7 @@ protected function getParallelExecutableFactory(`
`128`	`128`	`);`
`129`	`129`	`}`
`130`	`130`
`131`		`- protected function createErrorHandler(): ErrorHandler`
	`131`	`+ protected function createErrorHandler(OutputInterface $output): ErrorHandler`
`132`	`132`	`{`
`133`	`133`	`return new LoggingErrorHandler(`
`134`	`134`	`new ThrowableCodeErrorHandler(`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int`
`135`	`135`	`fn (int $count) => $this->getItemName($count),`
`136`	`136`	`$this->getName(),`
`137`	`137`	`$this->getDefinition(),`
`138`		`- $this->createErrorHandler(),`
	`138`	`+ $this->createErrorHandler($output),`
`139`	`139`	`)`
`140`	`140`	`->build()`
`141`	`141`	`->execute(`
`@@ -265,8 +265,7 @@ protected function getParallelExecutableFactory(`
`265`	`265`	`->withRunAfterBatch(Closure::fromCallable([$this, 'runAfterBatch']));`
`266`	`266`	`}`
`267`	`267`
`268`		`- // TODO: probably worth passing the output here in case`
`269`		`- protected function createErrorHandler(): ErrorHandler`
	`268`	`+ protected function createErrorHandler(OutputInterface $output): ErrorHandler`
`270`	`269`	`{`
`271`	`270`	`$errorHandler = new ThrowableCodeErrorHandler(`
`272`	`271`	`ResetServiceErrorHandler::forContainer($this->getContainer()),`