Rename PHP executable finder (#93)

- Rename the PHP executable finder from `detectPhpExecutable()` to `getPhpExecutable()` as the act of detecting it is an implementation detail, one could specify directly the desired executable.
- Make `getPhpExecutable()` non static. A user could for example want to get a specific path from the container in which case having access to an instance state is necessary.

Author: theofidry

src/Parallelization.php

@@ -15,23 +15,21 @@
 
 use function getcwd;
 use function realpath;
-use RuntimeException;
 use function sprintf;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Logger\ConsoleLogger;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Terminal;
 use Symfony\Component\DependencyInjection\ContainerInterface;
-use Symfony\Component\Process\PhpExecutableFinder;
-use Symfony\Component\Process\Process;
 use Webmozart\Assert\Assert;
 use Webmozarts\Console\Parallelization\ErrorHandler\ItemProcessingErrorHandler;
 use Webmozarts\Console\Parallelization\ErrorHandler\ItemProcessingErrorHandlerLogger;
 use Webmozarts\Console\Parallelization\ErrorHandler\ResetContainerErrorHandler;
 use Webmozarts\Console\Parallelization\Logger\DebugProgressBarFactory;
 use Webmozarts\Console\Parallelization\Logger\Logger;
 use Webmozarts\Console\Parallelization\Logger\StandardLogger;
+use Webmozarts\Console\Parallelization\Process\PhpExecutableFinder;
 
 /**
  * Adds parallelization capabilities to console commands.
@@ -229,9 +227,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             fn (string $item, InputInterface $input, OutputInterface $output) => $this->runSingleCommand($item, $input, $output),
             fn (int $count) => $this->getItemName($count),
             $this->getConsolePath(),
-            self::detectPhpExecutable(),
+            $this->getPhpExecutable(),
             $this->getName(),
-            self::getWorkingDirectory(),
+            $this->getWorkingDirectory(),
             $this->getExtraEnvironmentVariables(),
             $this->getDefinition(),
             $this->createItemErrorHandler(),
@@ -325,23 +323,17 @@ private static function getProgressSymbol(): string
     }
 
     /**
-     * Detects the path of the PHP interpreter.
+     * Returns the path of the PHP executable.
      */
-    private static function detectPhpExecutable(): string
+    private function getPhpExecutable(): string
     {
-        $php = (new PhpExecutableFinder())->find();
-
-        if (false === $php) {
-            throw new RuntimeException('Cannot find php executable');
-        }
-
-        return $php;
+        return PhpExecutableFinder::find();
     }
 
     /**
      * Returns the working directory for the child process.
      */
-    private static function getWorkingDirectory(): string
+    private function getWorkingDirectory(): string
     {
         return getcwd();
     }

src/Process/PhpExecutableFinder.php

@@ -0,0 +1,47 @@
+<?php
+
+/*
+ * This file is part of the Webmozarts Console Parallelization package.
+ *
+ * (c) Webmozarts GmbH <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Webmozarts\Console\Parallelization\Process;
+
+use Symfony\Component\Process\PhpExecutableFinder as SymfonyPhpExecutableFinder;
+use Webmozart\Assert\Assert;
+
+final class PhpExecutableFinder
+{
+    private static SymfonyPhpExecutableFinder $finder;
+
+    private function __construct()
+    {
+    }
+
+    public static function find(): string
+    {
+        $phpExecutable = self::getFinder()->find();
+
+        Assert::notFalse(
+            $phpExecutable,
+            'Could not find the PHP executable.',
+        );
+
+        return $phpExecutable;
+    }
+
+    private static function getFinder(): SymfonyPhpExecutableFinder
+    {
+        if (!isset(self::$finder)) {
+            self::$finder = new SymfonyPhpExecutableFinder();
+        }
+
+        return self::$finder;
+    }
+}