fix

Author: theofidry

tests/Fixtures/Command/DebugChildProcessCommand.php

@@ -22,13 +22,15 @@
 use Webmozarts\Console\Parallelization\ParallelExecutorFactory;
 use function file_put_contents;
 use function func_get_args;
+use function implode;
 use const LOCK_EX;
 
 final class DebugChildProcessCommand extends ParallelCommand
 {
     public const string OUTPUT_FILE = __DIR__.'/../../../dist/debug-child-input.txt';
 
-    private const string OPT_VALUE = 'optValue';
+    private const string SIMPLE_OPTION = 'simple-option';
+    private const string ARRAY_OPTION = 'array-option';
 
     private string $item = 'item';
     private ?Logger $logger = null;
@@ -44,10 +46,15 @@ protected function configure(): void
         parent::configure();
 
         $this->addOption(
-            self::OPT_VALUE,
+            self::SIMPLE_OPTION,
             null,
             InputOption::VALUE_OPTIONAL,
         );
+        $this->addOption(
+            self::ARRAY_OPTION,
+            null,
+            InputOption::VALUE_OPTIONAL + InputOption::VALUE_IS_ARRAY,
+        );
     }
 
     public function setItem(string $item): void
@@ -89,7 +96,8 @@ protected function runSingleCommand(string $item, InputInterface $input, OutputI
             self::OUTPUT_FILE,
             self::createContent(
                 $item,
-                $input->getOption(self::OPT_VALUE),
+                $input->getOption(self::SIMPLE_OPTION),
+                $input->getOption(self::ARRAY_OPTION),
             ),
             flags: LOCK_EX,
         );
@@ -102,11 +110,23 @@ protected function getItemName(?int $count): string
 
     public static function createContent(
         string $item,
-        ?string $option,
+        ?string $simpleOption,
+        array $arrayOption,
     ): string {
+        $normalizedArrayOption = implode(
+            "\n",
+            array_map(
+                static fn (string $option): string => "  - {$option}",
+                $arrayOption,
+            ),
+        );
+
         return <<<EOF
             Item: {$item}
-            Option: {$option}
+            Simple Option: {$simpleOption}
+            Array Option:
+            {$normalizedArrayOption}
+
             EOF;
     }
 }

tests/Integration/DebugChildProcessInputsTest.php

@@ -47,7 +47,8 @@ protected function tearDown(): void
     #[DataProvider('inputProvider')]
     public function test_it_can_run_the_command_without_sub_processes(
         string $item,
-        ?string $option,
+        ?string $simpleOption,
+        array $arrayOption,
         string $expected,
     ): void {
         $logger = new DummyLogger();
@@ -58,8 +59,8 @@ public function test_it_can_run_the_command_without_sub_processes(
         $this->commandTester->execute(
             [
                 'command' => 'debug:process',
-                '--optValue' => $option,
-                '-vvv' => null,
+                '--simple-option' => $simpleOption,
+                '--array-option' => $arrayOption,
             ],
             ['interactive' => true],
         );
@@ -73,48 +74,59 @@ public function test_it_can_run_the_command_without_sub_processes(
 
     public static function inputProvider(): iterable
     {
-        yield 'default' => [
-            'item',
-            null,
-            DebugChildProcessCommand::createContent(
-                'item',
-                '',
-            ),
-        ];
+        // This test fails...
+        // yield 'default' => [
+        //     'item',
+        //     null,
+        //     [],
+        //     DebugChildProcessCommand::createContent(
+        //         'item',
+        //         '',
+        //         [],
+        //     ),
+        // ];
 
         yield 'with values' => [
             'item',
             'option',
+            ['option1', 'option2'],
             DebugChildProcessCommand::createContent(
                 'item',
                 'option',
+                ['option1--array-option=option2'],
             ),
         ];
 
         yield 'escaped string token' => [
             '"foo"',
             '"bar"',
+            ['"option1"', '"option2"'],
             DebugChildProcessCommand::createContent(
                 '"foo"',
                 '"\"bar\""',
+                ['"\"option1\""--array-option="\"option2\""'],
             ),
         ];
 
         yield 'escaped string token with both types of quotes' => [
             '"o_id in(\'20\')"',
             '"p_id in(\'22\')"',
+            ['"option in(\'1\')"', '"option in(\'2\')"'],
             DebugChildProcessCommand::createContent(
                 '"o_id in(\'20\')"',
                 '"\"p_id in(\'22\')\""',
+                ['"\"option in(\'1\')\""--array-option="\"option in(\'2\')\""'],
             ),
         ];
 
         yield 'with values with spaces' => [
             'a b c d',
             'd c b a',
+            ['option 1', 'option 2'],
             DebugChildProcessCommand::createContent(
                 'a b c d',
                 '"d c b a"',
+                ['"option 1"--array-option="option 2"'],
             ),
         ];
     }