Skip to content

Commit 6197054

Browse files
authored
chore: Remove some TODOs (#286)
1 parent b903c8b commit 6197054

File tree

3 files changed

+1
-11
lines changed

3 files changed

+1
-11
lines changed

src/ChunkedItemsIterator.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,6 @@ private static function normalizeItemStream(mixed $items): Iterator
141141
$items,
142142
sprintf(
143143
'Expected the fetched items to be a list or an iterable of strings. Got "%s".',
144-
// TODO: use get_debug_type when dropping PHP 7.4 support
145144
get_debug_type($items),
146145
),
147146
);
@@ -164,7 +163,6 @@ private static function normalizeItem(mixed $item, int|string $index): string
164163
$item,
165164
sprintf(
166165
'The items are potentially passed to the child processes via the STDIN. For this reason they are expected to be string values. Got "%s" for the item "%s".',
167-
// TODO: use get_debug_type when dropping PHP 7.4 support
168166
get_debug_type($item),
169167
$index,
170168
),

src/Input/InputOptionsSerializer.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
use function array_map;
2323
use function implode;
2424
use function is_string;
25-
use function method_exists;
2625
use function preg_match;
2726
use function sprintf;
2827
use function str_replace;
@@ -71,8 +70,7 @@ private static function serializeOption(
7170
string $name,
7271
array|bool|float|int|string|null $value,
7372
): string {
74-
// TODO: remove the method exists check once we drop support for Symfony 4.4
75-
if (method_exists(InputOption::class, 'isNegatable') && $option->isNegatable()) {
73+
if ($option->isNegatable()) {
7674
return sprintf(
7775
'--%s%s',
7876
$value ? '' : 'no-',

src/Process/StandardSymfonyProcessFactory.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
use Symfony\Component\Process\InputStream;
1717
use Symfony\Component\Process\Process;
18-
use function method_exists;
1918

2019
final class StandardSymfonyProcessFactory implements SymfonyProcessFactory
2120
{
@@ -36,12 +35,7 @@ public function startProcess(
3635
);
3736

3837
$process->setInput($inputStream);
39-
// TODO: remove the following once dropping Symfony 4.4. Environment
40-
// variables are always inherited as of 5.0
4138
// @codeCoverageIgnoreStart
42-
if (method_exists($process, 'inheritEnvironmentVariables')) {
43-
$process->inheritEnvironmentVariables(true);
44-
}
4539
$process->start(
4640
static fn (string $type, string $buffer) => $processOutput(
4741
$index,

0 commit comments

Comments
 (0)