Fix e2e tests with actual sub-processes

Author: theofidry

.php_cs

@@ -11,6 +11,7 @@
 
 $finder = PhpCsFixer\Finder::create()
     ->in([
+        __DIR__.'/bin',
         __DIR__.'/src',
         __DIR__.'/tests'
     ])

bin/console

@@ -0,0 +1,15 @@
+#!/usr/bin/env php
+<?php
+
+declare(strict_types=1);
+
+require __DIR__.'/../vendor/autoload.php';
+
+use Symfony\Bundle\FrameworkBundle\Console\Application;
+use Webmozarts\Console\Parallelization\ImportMoviesCommand;
+use Webmozarts\Console\Parallelization\Kernel;
+
+$application = new Application(new Kernel());
+$application->add(new ImportMoviesCommand());
+
+$application->run();

composer.json

@@ -26,7 +26,10 @@
         "ext-json": "*",
         "friendsofphp/php-cs-fixer": "^2.15",
         "phpunit/phpunit": "^8.4",
-        "symfony/framework-bundle": "^4.1"
+        "symfony/config": "^4.1",
+        "symfony/event-dispatcher": "^4.1",
+        "symfony/framework-bundle": "^4.1",
+        "symfony/http-kernel": "^4.1"
     },
 
     "autoload": {

src/Parallelization.php

@@ -25,6 +25,7 @@
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Console\Logger\ConsoleLogger;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Terminal;
 use Symfony\Component\DependencyInjection\ContainerInterface;
@@ -395,7 +396,7 @@ protected function executeMasterProcess(InputInterface $input, OutputInterface $
                 self::getEnvironmentVariables($this->getContainer()),
                 $numberOfProcesses,
                 $segmentSize,
-                $this->getContainer()->get('logger', ContainerInterface::NULL_ON_INVALID_REFERENCE),
+                new ConsoleLogger($output),
                 function (string $type, string $buffer) use ($progressBar, $output, $terminalWidth) {
                     $this->processChildOutput($buffer, $progressBar, $output, $terminalWidth);
                 }

tests/ImportMoviesCommand.php

@@ -16,6 +16,7 @@
 use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use Webmozart\Assert\Assert;
 
 final class ImportMoviesCommand extends ContainerAwareCommand
 {
@@ -26,6 +27,25 @@ final class ImportMoviesCommand extends ContainerAwareCommand
      */
     protected static $defaultName = 'import:movies';
 
+    private $items;
+
+    private $segmentSize = 50;
+
+    /**
+     * @param string[]
+     */
+    public function setItems(array $items): void
+    {
+        Assert::allString($items);
+
+        $this->items = $items;
+    }
+
+    public function setSegmentSize(int $segmentSize): void
+    {
+        $this->segmentSize = $segmentSize;
+    }
+
     /**
      * {@inheritdoc}
      */
@@ -41,8 +61,9 @@ protected function fetchItems(InputInterface $input): array
     {
         // open up the file and read movie data...
 
-        // return items as strings
-        return [
+        // return items as strings; here return the injected items as priority
+        // for test purposes
+        return $this->items ?? [
             '{"id": 1, "name": "Star Wars"}',
             '{"id": 2, "name": "Django Unchained"}',
             // ...
@@ -65,6 +86,14 @@ protected function runAfterBatch(InputInterface $input, OutputInterface $output,
         // flush the database and clear the entity manager
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    protected function getSegmentSize(): int
+    {
+        return $this->segmentSize;
+    }
+
     /**
      * {@inheritdoc}
      */

tests/Kernel.php

@@ -0,0 +1,70 @@
+<?php
+
+/*
+ * This file is part of the Webmozarts Console Parallelization package.
+ *
+ * (c) Webmozarts GmbH <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Webmozarts\Console\Parallelization;
+
+use Symfony\Component\Config\Loader\LoaderInterface;
+use Symfony\Component\Console\Logger\ConsoleLogger;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Definition;
+use Symfony\Component\EventDispatcher\EventDispatcher;
+use Symfony\Component\HttpKernel\Kernel as HttpKernel;
+
+final class Kernel extends HttpKernel
+{
+    /**
+     * {@inheritdoc}
+     */
+    public function __construct()
+    {
+        parent::__construct('dev', true);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function registerBundles(): array
+    {
+        return [];
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function registerContainerConfiguration(LoaderInterface $loader): void
+    {
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function build(ContainerBuilder $container): void
+    {
+        $eventDispatcherDefinition = new Definition(
+            EventDispatcher::class,
+            []
+        );
+        $eventDispatcherDefinition->setPublic(true);
+
+        $loggerDefinition = new Definition(
+            ConsoleLogger::class,
+            []
+        );
+        $loggerDefinition->setPublic(true);
+
+        $container->addDefinitions([
+            'event_dispatcher' => $eventDispatcherDefinition,
+            'logger' => $loggerDefinition,
+        ]);
+    }
+}