-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script loops when trying to render issue 1074 #614
Comments
Wondering if it's because of the opening brace which is not closed. That would be a funny bug. |
The cause here is actually a regexp used to look for a closing tag. The DIV tag in my comment isn't closed, and processing this regular expression will never finish: |
(And it's not Firefox's fault - this thing fails in all browsers. Too many lookaheads, I guess..) |
@hallvors can you check to see if the latest has a fix? https://github.com/PrismJS/prism |
The problematic regexp is still there: |
Probably worth filing a proper bug upstream then. Or submitting a patch. :) |
(I went ahead and edited your comment to close the div as a workaround). |
This is very odd. Can you reproduce in Prism’s test drive page? If so, could you file an issue on Prism’s repo? This is serious, and would be very high priority. |
Thanks @LeaVerou -- reported. |
https://webcompat.com/issues/1074 seems to send some part of our JS (the Prism highlighter/tokenizer?) into a never-ending loop, causing a "slow script" dialog.
If there's a newer version of Prism we can try upgrading - else we need to dig into the tokenizer logic. I'm happy to do that :)
The text was updated successfully, but these errors were encountered: