Skip to content

Browser detection recognizes Edge as Chrome #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Th3S4mur41 opened this issue Nov 11, 2019 · 5 comments
Closed

Browser detection recognizes Edge as Chrome #3085

Th3S4mur41 opened this issue Nov 11, 2019 · 5 comments

Comments

@Th3S4mur41
Copy link

In the issue form, the autofilled browser version when using Edge is Chrome.
The same issue is true for both Edge (Canary) on Windows as well as on Android.
While both Browser are based on the same Engine, different settings might lead to different behaviors.
So I think it would make sense to recognize Edge as such.

@miketaylr
Copy link
Member

Thanks for the report @Th3S4mur41, I agree we should recognize Edge differently from Chrome.

@miketaylr
Copy link
Member

miketaylr commented Nov 12, 2019

It looks like a fix is already waiting to be merged at ua-parser/uap-core#401

edit: oh, it was already merged.

@miketaylr
Copy link
Member

So the update is in uap-core 0.6.10, but currently uap-python is using 0.6.9: ua-parser/uap-core@71ec72c...286809e

I filed ua-parser/uap-python#78

@karlcow
Copy link
Member

karlcow commented Jan 3, 2020

This should be fixed soon.
ua-parser/uap-python#79

@miketaylr
Copy link
Member

This is fixed by #3413.
Screen Shot 2020-07-24 at 10 00 36 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants