Skip to content

GitHub username text is unclear #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinthomson opened this issue Feb 4, 2019 · 5 comments
Closed

GitHub username text is unclear #2791

martinthomson opened this issue Feb 4, 2019 · 5 comments

Comments

@martinthomson
Copy link

This text...

Sharing your GitHub username—without logging in—could help us with diagnosis. This will be publicly visible.

... combined with the two buttons "Report Anonymously" and "Report via GitHub" is confusing.

The without logging in might be read to imply that you are not going to be required to authorize an application or log in even if you choose the "Report via GitHub" option. That is not the case.

Also, "This will be publicly visible" might be read to imply that none of the other information will be. It's all public info (#2690).

My suggestion:

Your GitHub username (optional):
[ @github-username ]
[ Report ] [ Login and Report ]

With the latter only becoming accessible when a GitHub username is entered (I think that this is already the case, but I didn't double-check).

@karlcow
Copy link
Member

karlcow commented Feb 5, 2019

@martinthomson thanks for the comment.

Currently the flow is this (and sure can be improved as we are testing for the last couple of weeks this new feature aka github username)

  1. Report Anonymously
  2. Report Anonymously + GitHub username (which will add the username to the report, without the person having to login)
  3. Report via GitHub (login process)

The difference in between 2 and 3 is that people do not have to give webcompat so many permissions. See #655 This was the intent to cater for people who are uncomfortable with this big list of permissions.

Also the GitHub username field is only visible if the user is not already logged in. The flow you are proposing is not exactly doing the same thing (if I understood).

@martinthomson
Copy link
Author

Thanks @karlcow,

I'm not suggesting a change in process. I think that these are the right reporting flows, given the constraints as I understand them. All I'm doing here is trying to suggest using different words on the form to better communicate what is going to happen.

@karlcow
Copy link
Member

karlcow commented Feb 6, 2019

This relates to #2762 too.

@karlcow
Copy link
Member

karlcow commented Apr 25, 2019

@martinthomson

We changed things a bit. The username is not hotlinked anymore.
see https://webcompat.com/issues/29931

Capture d’écran 2019-04-25 à 12 58 04
Capture d’écran 2019-04-25 à 12 58 23

And the wording has been tweaked.

Capture d’écran 2019-04-25 à 13 01 29

Let's see if that improves thing a bit.

Thanks for the feedback.

@karlcow karlcow closed this as completed Apr 25, 2019
@martinthomson
Copy link
Author

Maybe remove the "publicly visible" bit from the github username field. It is redundant now (and thus still a little confusing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants