Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing guidelines - npm run init #1176

Closed
luiguild opened this issue Sep 18, 2016 · 8 comments
Closed

contributing guidelines - npm run init #1176

luiguild opened this issue Sep 18, 2016 · 8 comments

Comments

@luiguild
Copy link

In Working Environment Setup[1] I found the instruction

# clone the repo
git clone https://github.com/<username>/webcompat.com.git #replace your github username
# change to directory
cd webcompat.com
# check out submodules
npm run module
# initializing project
[sudo] npm init

npm init? The package.json file already exists... Right?
I guess that the correct step is

npm install

or am I wrong?

😄

1 - https://github.com/webcompat/webcompat.com/blob/master/CONTRIBUTING.md#working-environment-setup

@denschub
Copy link
Member

Hm, this probably should be npm run init instead of npm init. That comment will set pretty much everything up for you.

Do you want to make a pull request for that? :)

@magsout
Copy link
Member

magsout commented Sep 20, 2016

Hum, maybe I was wrong to write, npm run init it's not a good things to overwrite default recipes

@miketaylr
Copy link
Member

Maybe we should rename that? npm run bootstrap or npm run setup??

@luiguild
Copy link
Author

Personally I prefer npm run setup

@miketaylr
Copy link
Member

@luiguild did you ever get the development environment working for you?

@karlcow karlcow changed the title Little doubt on guidelines for contributing contributing guidelines - npm run init Feb 2, 2017
@karlcow
Copy link
Member

karlcow commented Feb 2, 2017

In #982 @miketaylr used npm run init does it fix this issue?

@zoepage
Copy link
Member

zoepage commented Feb 2, 2017

I ran into the same issue while setup.
Either way the rename should be a good step to prevent confusion. :)

@miketaylr
Copy link
Member

@zoepage is handling the rename in #1322, so let's close here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants