Skip to content

Commit f7d3956

Browse files
committed
Merge pull request #403 from webcompat/Labels-component
Labels component
2 parents 66cf0a5 + b19173d commit f7d3956

File tree

5 files changed

+40
-3
lines changed

5 files changed

+40
-3
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
/*---------- Labels ----------*/
2+
3+
.wc-Labels {
4+
display: inline-block;
5+
border-width:0 0 3px 0;
6+
border-style:solid;
7+
font-weight:700;
8+
border-color:transparent;
9+
opacity:.7;
10+
}
11+
/* state */
12+
.wc-Labels:hover {
13+
text-decoration:none;
14+
opacity:1;
15+
}

webcompat/static/css/development/main.css

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
@import "components/hero.css";
2929
@import "components/filter.css";
3030
@import "components/pagination.css";
31+
@import "components/labels.css";
3132
/*----------Layout----------*/
3233
@import "layout/body.css";
3334
@import "layout/utilities.css";

webcompat/static/css/development/page/issue-list.css

+5
Original file line numberDiff line numberDiff line change
@@ -69,4 +69,9 @@
6969
/* modifier : label */
7070
.IssueList-noResults-list-item--label {
7171
list-style: none;
72+
padding-top:.8em;
73+
}
74+
/* labels item */
75+
.IssueList-noResults-list-labelsItem {
76+
display:inline-block;
7277
}

webcompat/static/js/lib/issue-list.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ issueList.PaginationControlsView = Backbone.View.extend({
236236
issueList.IssueView = Backbone.View.extend({
237237
el: $('.js-issue-list'),
238238
events: {
239-
'click .IssueItem-label': 'labelSearch'
239+
'click .js-issue-label': 'labelSearch',
240240
},
241241
initialize: function() {
242242
this.issues = new issueList.IssueCollection();

webcompat/templates/issue-list.html

+18-2
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ <h2 class="wc-margin-bottom">Issues</h2>
7070
</p>
7171
</div>
7272
<div class="IssueItem-section">
73-
<span class="IssueItem-label"><% _.each(issue.labels, function(label) { %>
74-
<a href="#" class="wc-bold"><%= label.name %></a>
73+
<span class="IssueItem-label js-issue-label"><% _.each(issue.labels, function(label) { %>
74+
<a href="#" class="wc-Labels" title="Labels : <%= label.name %>"><%= label.name %></a>
7575
<% }); %></span>
7676
</div>
7777
</div>
@@ -83,6 +83,22 @@ <h2 class="wc-margin-bottom">Issues</h2>
8383
<li class="IssueList-noResults-list-item">Check your spelling</li>
8484
<li class="IssueList-noResults-list-item">Try a more general search</li>
8585
<li class="IssueList-noResults-list-item">Filter by popular labels</li>
86+
<li class="IssueList-noResults-list-item IssueList-noResults-list-item--label">
87+
<ul class="r-ResetList IssueList-noResults-list-labels">
88+
<li class="IssueList-noResults-list-labelsItem js-issue-label" >
89+
<a class="wc-Labels" href="#" title="Labels : android" style="border-color: #48DE20">android</a>
90+
</li>
91+
<li class="IssueList-noResults-list-labelsItem js-issue-label">
92+
<a class="wc-Labels" href="#" title="Labels : chrome" style="border-color: #FFA500">chrome</a>
93+
</li>
94+
<li class="IssueList-noResults-list-labelsItem js-issue-label">
95+
<a class="wc-Labels" href="#" title="Labels : firefox" style="border-color: #E50000">firefox</a>
96+
</li>
97+
<li class="IssueList-noResults-list-labelsItem js-issue-label">
98+
<a class="wc-Labels" href="#" title="Labels : ie" style="border-color: #3E8AE5">ie</a>
99+
</li>
100+
</ul>
101+
</li>
86102
</ul>
87103
</div>
88104
<% } %>

0 commit comments

Comments
 (0)