Issue #1030. Be more paranoid and make sure we have a string before parsing a UA.

Author: Mike Taylor

tests/test_helpers.py

@@ -136,6 +136,10 @@ def test_get_browser_name(self):
         self.assertEqual(get_browser_name(None), 'unknown')
         self.assertEqual(get_browser_name(), 'unknown')
         self.assertEqual(get_browser_name(u'💀'), 'unknown')
+        self.assertEqual(get_browser('<script>lol()</script>'), 'Unknown')
+        self.assertEqual(get_browser(True), 'Unknown')
+        self.assertEqual(get_browser(False), 'Unknown')
+        self.assertEqual(get_browser(None), 'Unknown')
 
     def test_get_browser(self):
         '''Test Browser parsing for non-tablet devices.'''
@@ -151,9 +155,12 @@ def test_get_browser(self):
                          'Chrome Mobile 18.0.1025')
         self.assertEqual(get_browser(CHROME_TABLET_UA), 'Chrome 18.0.1025')
         self.assertEqual(get_browser(''), 'Unknown')
-        self.assertEqual(get_browser(None), 'Unknown')
         self.assertEqual(get_browser(), 'Unknown')
         self.assertEqual(get_browser(u'💀'), 'Unknown')
+        self.assertEqual(get_browser('<script>lol()</script>'), 'Unknown')
+        self.assertEqual(get_browser(True), 'Unknown')
+        self.assertEqual(get_browser(False), 'Unknown')
+        self.assertEqual(get_browser(None), 'Unknown')
 
 if __name__ == '__main__':
     unittest.main()

webcompat/helpers.py

@@ -104,7 +104,7 @@ def get_browser(user_agent_string=None):
 
     It will pre-populate the bug reporting form.
     '''
-    if user_agent_string:
+    if user_agent_string and isinstance(user_agent_string, basestring):
         ua_dict = user_agent_parser.Parse(user_agent_string)
         ua = ua_dict.get('user_agent')
         name = ua.get('family')
@@ -137,7 +137,7 @@ def get_browser_name(user_agent_string=None):
 
     unknown user agents will be reported as "unknown".
     '''
-    if user_agent_string:
+    if user_agent_string and isinstance(user_agent_string, basestring):
         # get_browser will return something like 'Chrome Mobile 47.0'
         # we just want 'chrome mobile', i.e., the lowercase name
         # w/o the version
@@ -150,7 +150,7 @@ def get_os(user_agent_string=None):
 
     It pre-populates the bug reporting form.
     '''
-    if user_agent_string:
+    if user_agent_string and isinstance(user_agent_string, basestring):
         ua_dict = user_agent_parser.Parse(user_agent_string)
         os = ua_dict.get('os')
         version = os.get('major', u'Unknown')