Skip to content

Commit d703074

Browse files
karlcowMike Taylor
authored and
Mike Taylor
committed
#451 rewrite sanitize using parsing and formatting
1 parent f47d6b6 commit d703074

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

webcompat/helpers.py

+4-11
Original file line numberDiff line numberDiff line change
@@ -208,17 +208,10 @@ def rewrite_links(link_header):
208208
def sanitize_link(link_header):
209209
'''Remove any oauth tokens from the Link header that GitHub gives to us,
210210
and return a rewritten Link header (see rewrite_links)'''
211-
links_list = link_header.split(',')
212-
clean_links_list = []
213-
for link in links_list:
214-
uri_info, rel_info = link.split(';')
215-
uri_info = uri_info.strip()
216-
rel_info = rel_info.strip()
217-
uri = uri_info[1:-1]
218-
clean_uri = remove_oauth(uri)
219-
clean_links_list.append('<{0}>; {1}'.format(
220-
urlparse.urlunparse(clean_uri), rel_info))
221-
return ', '.join(clean_links_list)
211+
header_link_data = parse_link_header(link_header)
212+
for data in header_link_data:
213+
data['link'] = remove_oauth(data['link'])
214+
return format_link_header(header_link_data)
222215

223216

224217
def remove_oauth(uri):

0 commit comments

Comments
 (0)