Merge pull request #782 from /issues/773/2

Fixes #773. Prevent caching empty labels responses from GitHub

Author: karlcow

requirements.txt

@@ -1,6 +1,5 @@
 Babel==1.3
 Flask==0.10.1
-Flask-Cache==0.13.1
 Flask-Limiter==0.7.4
 Flask-SQLAlchemy==1.0
 Flask-Uploads==0.1.3

webcompat/__init__.py

@@ -9,15 +9,13 @@
 import logging
 import os
 
-from flask.ext.cache import Cache
 from flask.ext.github import GitHub
 from flask.ext.limiter import Limiter
 from flask import Flask
 
 app = Flask(__name__, static_url_path='')
 app.config.from_object('config')
 
-cache = Cache(app)
 github = GitHub(app)
 limiter = Limiter(app)
 

webcompat/api/endpoints.py

@@ -18,7 +18,6 @@
 
 
 from webcompat import app
-from webcompat import cache
 from webcompat import github
 from webcompat import limiter
 from webcompat.helpers import get_comment_data
@@ -157,8 +156,6 @@ def get_search_results(query_string=None, params=None):
 
     This method can take a query_string argument, to be called from other
     endpoints, or the query_string can be passed in via the Request object.
-
-    Not cached.
     '''
     params = params or request.args.copy()
     query_string = query_string or params.get('q')
@@ -258,12 +255,8 @@ def modify_labels(number):
 
 
 @api.route('/issues/labels')
-@cache.cached(timeout=600)
 def get_repo_labels():
-    '''XHR endpoint to get all possible labels in a repo.
-
-    Cached for 10 minutes.
-    '''
+    '''XHR endpoint to get all possible labels in a repo.'''
     if g.user:
         request_headers = get_request_headers(g.request_headers)
         path = 'repos/{0}/labels'.format(REPO_PATH)