Skip to content

Commit abcd840

Browse files
author
Mike Taylor
authored
Merge pull request #3416 from webcompat/issue/3392-css/1
Fixes #3392 - Refactor css after original form removal
2 parents f002003 + b489e64 commit abcd840

File tree

10 files changed

+28
-281
lines changed

10 files changed

+28
-281
lines changed

webcompat/static/css/src/footer.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.footer-item {
2-
border-bottom: 1px solid var(--color-form);
2+
border-bottom: 1px solid var(--color-footer);
33
padding: var(--unit-space) var(--unit-gap);
44
}
55

webcompat/static/css/src/form.css

+11-65
Original file line numberDiff line numberDiff line change
@@ -11,52 +11,13 @@
1111
padding: 10px 0 35px;
1212
}
1313

14-
.form-element-bottom {
15-
display: flex;
16-
flex-flow: column nowrap;
17-
}
18-
19-
.form-element-bottom .form-button {
20-
margin-top: auto;
21-
}
22-
2314
.form-element {
2415
margin: 0 0 20px;
2516
max-width: 100%;
2617
padding: 0;
2718
position: relative;
2819
}
2920

30-
.form-button-multiple {
31-
align-items: center;
32-
display: flex;
33-
flex-wrap: wrap;
34-
justify-content: space-between;
35-
margin-left: -10px;
36-
margin-right: -10px;
37-
max-width: none;
38-
}
39-
40-
.form-button-multiple .button-wrapper {
41-
cursor: pointer;
42-
display: flex;
43-
flex: 1 1 auto;
44-
margin: 20px 10px 0;
45-
position: relative;
46-
}
47-
48-
.form-button-multiple .button-wrapper .button {
49-
flex: 1;
50-
}
51-
52-
.form-button-multiple .button-wrapper .button:disabled {
53-
pointer-events: none;
54-
}
55-
56-
.form-button-multiple .button-wrapper:hover .button {
57-
opacity: .85;
58-
}
59-
6021
.form-field {
6122
background: none;
6223
color: inherit;
@@ -87,13 +48,6 @@
8748
visibility: hidden;
8849
}
8950

90-
.form-required::after {
91-
color: var(--color-error);
92-
content: "*";
93-
padding-left: 7px;
94-
padding-right: 7px;
95-
}
96-
9751
.form-label-message .form-label {
9852
display: inline-block;
9953
}
@@ -105,15 +59,6 @@
10559
font-weight: 700;
10660
}
10761

108-
/* form text privacy */
109-
.form-text-privacy {
110-
background-color: var(--base-colorDark);
111-
border-radius: 5px;
112-
font-size: 14px;
113-
padding: 6px;
114-
text-align: center;
115-
}
116-
11762
/* * Form input[type="text"], textarea (text-field) */
11863

11964
.text-field {
@@ -126,27 +71,28 @@
12671
min-height: 27px;
12772
padding: 8px 24px 8px 8px;
12873
position: relative;
74+
transition: box-shadow .3s;
12975
width: 100%;
13076
z-index: 2;
13177
}
13278

13379
.text-field:focus {
134-
border-bottom: 1px solid var(--color-first);
80+
box-shadow: 0 0 0 2px var(--issue-type-bg);
13581
outline: 1px solid transparent;
136-
transition: border-bottom 1s linear;
13782
}
13883

139-
/* * Form input[type="text"] validation */
84+
@media (min-width: 665px) {
85+
.text-field {
86+
font-size: 100%;
87+
}
14088

141-
.form-input-validation {
142-
display: inline-block;
143-
position: relative;
144-
text-align: right;
145-
top: -2em;
146-
width: 100%;
147-
z-index: 0;
89+
.text-field:focus {
90+
box-shadow: 0 0 0 3px var(--issue-type-bg);
91+
}
14892
}
14993

94+
/* * Form input[type="text"] validation */
95+
15096
.is-validated .check::after {
15197
background-image: url("../../img/svg/icons/svg-checkmark.svg");
15298
background-repeat: no-repeat;

webcompat/static/css/src/issue-wizard-textarea.css

-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@
2020
width: 100%;
2121
}
2222

23-
.progress-textarea .text-field {
24-
font-weight: 200;
25-
}
26-
2723
.progress-textarea .progress {
2824
background: #b3f4d7;
2925
border-radius: 2px;

webcompat/static/css/src/issue-wizard.css

+6-24
Original file line numberDiff line numberDiff line change
@@ -435,11 +435,7 @@
435435
}
436436

437437
.issue-form .text-field {
438-
border-color: var(--screenshot-shadow);
439-
font-size: 14px;
440-
font-weight: 200;
441438
padding: 4px 32px 5px 8px;
442-
transition: box-shadow .3s;
443439
}
444440

445441
.with-validation-icons.is-validated .input-wrapper::after,
@@ -487,9 +483,6 @@
487483
}
488484

489485
.low .text-field {
490-
border-radius: 2px;
491-
color: var(--color-second);
492-
font-weight: 200;
493486
margin-bottom: 17px;
494487
padding: 5px 32px 7px 8px;
495488
}
@@ -498,8 +491,8 @@
498491
border-color: var(--wizard-step-error);
499492
}
500493

501-
.low .text-field::placeholder {
502-
color: var(--input-placeholder);
494+
.issue-form .is-validated .text-field {
495+
border-color: var(--issue-selected-outline);
503496
}
504497

505498
.issue-btn {
@@ -653,14 +646,6 @@
653646
width: 28px;
654647
}
655648

656-
.issue-form .is-validated .text-field {
657-
border-color: var(--issue-selected-outline);
658-
}
659-
660-
.issue-form .text-field:focus {
661-
box-shadow: 0 0 0 3px var(--issue-type-bg);
662-
}
663-
664649
#browsers li {
665650
width: 33%;
666651
}
@@ -1031,18 +1016,15 @@
10311016
display: none;
10321017
}
10331018

1034-
.issue-form .text-field {
1035-
border-color: var(--color-form);
1036-
font-size: 90%;
1019+
.step-url .text-field {
10371020
font-weight: 600;
1021+
}
1022+
1023+
.issue-form .text-field {
10381024
padding: 11px 36px 11px 8px;
10391025
}
10401026

10411027
.low .text-field {
1042-
border-radius: 2px;
1043-
color: var(--color-second);
1044-
font-weight: 200;
1045-
margin-bottom: 17px;
10461028
padding: 5px 32px 7px 8px;
10471029
}
10481030

webcompat/static/css/src/issue.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
}
6767

6868
.issue-new-comment .form-text {
69-
padding: 0;
69+
padding: 4px;
7070
}
7171

7272
.issue-new-comment .text-field {

webcompat/static/css/src/issues-list.css

+2-2
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@
9191
}
9292

9393
#x-search-bar .nav-button {
94-
margin-left: -22px;
95-
margin-top: -29px;
94+
margin-left: -26px;
95+
margin-top: -30px;
9696
position: absolute;
9797
z-index: 200;
9898
}

webcompat/static/css/src/label-editor.css

+2-13
Original file line numberDiff line numberDiff line change
@@ -142,19 +142,8 @@
142142
}
143143

144144
.label-editor-header .nav-button {
145-
margin-top: -10px;
146-
}
147-
148-
@media all and (min-width: 893.01px) {
149-
.label-editor-header .nav-button {
150-
margin-right: 5px;
151-
}
152-
}
153-
154-
@media all and (max-width: 893px) {
155-
.label-editor-header .nav-button {
156-
margin-right: -1px;
157-
}
145+
margin-left: 10px;
146+
margin-top: -2px;
158147
}
159148

160149
.wc-Issue-categoryEditor-button .label-editorLauncher {

webcompat/static/css/src/nav.css

+3-2
Original file line numberDiff line numberDiff line change
@@ -83,9 +83,10 @@
8383
margin: 0 auto;
8484
max-width: var(--unit-modul-l);
8585
min-width: var(--unit-modul-s);
86+
padding: 0 10px;
8687
position: absolute;
8788
right: 0;
88-
top: 1px;
89+
top: 5px;
8990
transform: rotateY(-90deg);
9091
transition: all .2s ease 0s;
9192
visibility: hidden;
@@ -108,7 +109,7 @@
108109
float: right;
109110
position: relative;
110111
right: 10px;
111-
top: -35px;
112+
top: -32px;
112113
z-index: 1300;
113114
}
114115

webcompat/static/css/src/variables.css

+2-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
--color-second: rgba(64, 64, 64, 1); /* #404040 */
2929
--color-third: rgba(240, 240, 240, 1); /* #f0f0f0 */
3030
--color-fourth: rgba(192, 255, 238, 1); /* #c0ffee */
31-
--color-form: rgba(0, 0, 0, .12); /* #000000 88% transparency */
31+
--color-form: rgba(0, 0, 0, .4); /* #000000 40% transparency */
32+
--color-footer: rgba(0, 0, 0, .12); /* #000000 12% transparency */
3233
--color-default: rgba(196, 196, 196, 1); /* c4c4c4 */
3334
--color-error: rgba(204, 23, 23, 1); /* #CC1717 */
3435
--color-error-transparent: rgba(204, 23, 23, .8); /* #CC1717 20% transparency */

0 commit comments

Comments
 (0)