Skip to content

Commit 8af3aca

Browse files
committed
Issue #855 - fixed broken test
1 parent 5919a85 commit 8af3aca

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

tests/functional/contributors-non-auth.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ define([
3838
assert.notInclude('is-open', className);
3939
})
4040
.end()
41-
.findByCssSelector('.wc-Hero-img').getAttribute('class')
41+
.findByCssSelector('.wc-Hero-SVG').getAttribute('class')
4242
.then(function(className) {
4343
assert.notEqual('is-active', className);
4444
})
@@ -54,7 +54,7 @@ define([
5454
assert.equal(isDisplayed, true);
5555
})
5656
.end()
57-
.findByCssSelector('.wc-Hero-img.is-active').isDisplayed()
57+
.findByCssSelector('.wc-Hero-SVG.is-active').isDisplayed()
5858
.then(function(isDisplayed) {
5959
assert.equal(isDisplayed, true);
6060
})
@@ -66,7 +66,7 @@ define([
6666
assert.notInclude('is-open', className);
6767
})
6868
.end()
69-
.findByCssSelector('.wc-Hero-img').getAttribute('class')
69+
.findByCssSelector('.wc-Hero-SVG').getAttribute('class')
7070
.then(function(className) {
7171
assert.notInclude('is-active', className);
7272
});
@@ -76,14 +76,14 @@ define([
7676
return this.remote
7777
.setFindTimeout(intern.config.wc.pageLoadTimeout)
7878
.get(require.toUrl(url('/contributors')))
79-
.findByCssSelector('.wc-Hero-img.is-active').isDisplayed()
79+
.findByCssSelector('.wc-Hero-SVG.is-active').isDisplayed()
8080
.then(function(isDisplayed) {
8181
assert.equal(isDisplayed, true);
8282
})
8383
.end()
8484
.findByCssSelector('.contributors__item__title').click()
8585
.end()
86-
.findByCssSelector('.wc-Hero-img').getAttribute('class')
86+
.findByCssSelector('.wc-Hero-SVG').getAttribute('class')
8787
.then(function(className) {
8888
assert.notInclude('is-active', className);
8989
});

webcompat/static/css/development/components/hero.css

+1-5
Original file line numberDiff line numberDiff line change
@@ -122,12 +122,8 @@
122122
.wc-Hero--contributors .wc-Hero-light {
123123
height:15em;
124124
}
125-
126-
.wc-Hero--contributors .wc-Hero-lightFilament {
127-
fill : #F0F0F0;
128-
}
129125
/* is-active */
130-
.wc-Hero-img.is-active .wc-Hero-lightFilament {
126+
.wc-Hero-SVG.is-active .wc-Hero-lightFilament {
131127
fill: #E4BD0C;
132128
}
133129
@media (--viewport-600px) {

webcompat/templates/contributors.html

+4-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@
1010
<h1 class="wc-Hero-title wc-Title--xl">Welcome aboard!<br/>Get started below...</h1>
1111
</div>
1212
<div class="wc-Hero-section wc-Hero-section--right">
13-
{% include "shared/LightbulbwithBug.svg" %}
13+
<div class="wc-Hero-SVG is-active">
14+
{% include "shared/LightbulbwithBug.svg" %}
15+
</div>
1416
</div>
1517
</div>
1618
</div>
@@ -79,7 +81,7 @@ <h2 id="contribute">
7981
{%- block extrascripts -%}
8082
<script>
8183
$(function(){
82-
var lightElm = $('.wc-Hero-img');
84+
var lightElm = $('.wc-Hero-SVG');
8385
var sections = $('.contributors__item__content');
8486
var ACTIVE_CLASS = 'is-active';
8587
var OPEN_CLASS = 'is-open';
Loading

0 commit comments

Comments
 (0)