Skip to content

Commit 8094eac

Browse files
committed
Issue #1938. Update tests.
1 parent 12881c0 commit 8094eac

File tree

1 file changed

+26
-4
lines changed

1 file changed

+26
-4
lines changed

tests/test_webhook.py

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,13 @@ def setUp(self):
5050
<!-- @browser: Firefox 55.0 -->
5151
<!-- @ua_header: Mozilla/5.0 (what) Gecko/20100101 Firefox/55.0 -->
5252
<!-- @reported_with: web -->
53+
<!-- @extra_label: type-media -->
5354
5455
**URL**: https://www.example.com/
5556
**Browser / Version**: Firefox 55.0
5657
<!-- @browser: Chrome 48.0 -->
5758
"""
59+
5860
self.issue_body2 = """
5961
<!-- @browser: Foobar -->
6062
"""
@@ -66,6 +68,10 @@ def setUp(self):
6668
**URL**: https://www.google.com/
6769
<!-- @browser: Firefox Mobile (Tablet) 40.0 -->
6870
"""
71+
self.issue_body5 = """
72+
<!-- @browser: Foobar99.0 -->
73+
<!-- @browser: Foobar 99.0 -->
74+
"""
6975

7076
def tearDown(self):
7177
"""Tear down tests."""
@@ -133,15 +139,31 @@ def test_fails_on_not_known_action(self):
133139

134140
def test_extract_browser_label(self):
135141
"""Extract browser label name."""
136-
browser_label = helpers.extract_browser_label(self.issue_body)
142+
browser_label = helpers.extract_browser_label(
143+
helpers.extract_metadata(self.issue_body))
137144
self.assertEqual(browser_label, 'browser-firefox')
138-
browser_label_none = helpers.extract_browser_label(self.issue_body2)
145+
browser_label_none = helpers.extract_browser_label(
146+
helpers.extract_metadata(self.issue_body2))
139147
self.assertEqual(browser_label_none, None)
140-
browser_label_paren = helpers.extract_browser_label(self.issue_body3)
148+
browser_label_paren = helpers.extract_browser_label(
149+
helpers.extract_metadata(self.issue_body3))
141150
self.assertEqual(browser_label_paren, 'browser-firefox-mobile-tablet')
142-
browser_label_unicode = helpers.extract_browser_label(self.issue_body4)
151+
browser_label_unicode = helpers.extract_browser_label(
152+
helpers.extract_metadata(self.issue_body4))
143153
self.assertEqual(
144154
browser_label_unicode, 'browser-firefox-mobile-tablet')
155+
browser_label_none2 = helpers.extract_browser_label(
156+
helpers.extract_metadata(self.issue_body5))
157+
self.assertEqual(browser_label_none2, None)
158+
159+
def test_extract_extra_label(self):
160+
"""Extract 'extra' label."""
161+
extra_label = helpers.extract_extra_label(
162+
helpers.extract_metadata(self.issue_body))
163+
self.assertEqual(extra_label, 'type-media')
164+
extra_label_none = helpers.extract_extra_label(
165+
helpers.extract_metadata(self.issue_body2))
166+
self.assertEqual(extra_label_none, None)
145167

146168
def test_extract_priority_label(self):
147169
"""Extract priority label."""

0 commit comments

Comments
 (0)