Skip to content

Commit 50c03e2

Browse files
committed
chore: add changes from PR 679,683,684
1 parent 3cc2976 commit 50c03e2

File tree

6 files changed

+9
-10
lines changed

6 files changed

+9
-10
lines changed

packages/core/src/lib/Checkbox/Checkbox.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const Checkbox: React.FC<CheckboxProps> = ({
1313
label,
1414
labelWhenChecked,
1515
layout = 'box',
16-
name,
16+
name = '',
1717
onChange,
1818
onBlur,
1919
validation,

packages/core/src/lib/Checkbox/types.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
2-
31
export type ValidateCheckbox = {
42
required?: boolean;
53
};
@@ -43,7 +41,7 @@ export interface CheckboxProps {
4341
/**
4442
* a name attribute to group checkboxes
4543
*/
46-
name: string;
44+
name?: string;
4745

4846
/**
4947
* The normal onChange event

packages/core/src/lib/LinkTo/LinkTo.stories.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ NoIconLink.args = {
110110
address: '[email protected]',
111111
text: 'Email Us',
112112
type: 'email',
113+
iconLayout: 'none',
113114
};
114115

115116
export const InternalLink: ComponentStory<typeof LinkTo> = Template.bind({});

packages/core/src/lib/LinkTo/LinkTo.styles.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ const SpanStyledFlex = styled.span<TStyleProps>`
4444
flex-direction: ${({ iconLayout }) =>
4545
iconLayout === 'leading' ? 'row' : 'row-reverse'};
4646
margin: ${(p) =>
47-
p.iconLayout === 'leading' ? '0 2px 0 4px' : '0 4px 0 2px'};
47+
p.iconLayout === 'leading' ? 'auto 2px auto 4px' : 'auto 4px auto 2px'};
4848
4949
svg {
5050
margin: ${(p) =>
51-
p.iconLayout === 'leading' ? '0 4px 0 0' : '0 0 0 4px'};
51+
p.iconLayout === 'leading' ? 'auto 4px auto 0' : 'auto 0 auto 4px'};
5252
}
5353
`;
5454

packages/core/src/lib/LinkTo/LinkTo.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const LinkTo: React.FC<LinkToProps> = ({
1010
address,
1111
text,
1212
type = 'external',
13-
iconLayout = 'none',
13+
iconLayout = 'leading',
1414
...props
1515
}) => {
1616
const renderContent = () => (
@@ -22,15 +22,15 @@ const LinkTo: React.FC<LinkToProps> = ({
2222
title="mail icon"
2323
titleId="linkto mail icon"
2424
fill={color.blue}
25-
fontSize={24}
25+
fontSize={18}
2626
style={{ marginTop: 'auto' }}
2727
/>
2828
) : (
2929
<Link
3030
title="link icon"
3131
titleId="linkto link icon"
3232
fill={color.blue}
33-
fontSize={24}
33+
fontSize={18}
3434
style={{ marginTop: 'auto' }}
3535
/>
3636
))}

packages/core/src/lib/Todo/Todo.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ const Todo: React.FC<TodoProps> = ({
4444
};
4545

4646
const addTodo = () => {
47+
if (inputValue == '') return;
4748
setLists((prevTodo) => Array.from(new Set([...prevTodo, inputValue])));
4849
setInputValue('');
4950
const input: HTMLInputElement | null = document.querySelector(
@@ -63,7 +64,6 @@ const Todo: React.FC<TodoProps> = ({
6364
size="large"
6465
validation={{
6566
regExp: pattern,
66-
required: true,
6767
}}
6868
key={key}
6969
value={inputValue}

0 commit comments

Comments
 (0)