VT: Handle empty render pass captures

vmpstr · chromium-wpt-export-bot · commit 6f31f8090940 · 2025-04-23T13:04:59.000-07:00
If the render pass has an empty output rect, we try to create an empty texture for it, which isn't allowed. This patch makes it instead reuse the empty (non-existent) render pass path to treat it as an empty capture, which is what is expected. R=khushalsagar@chromium.org Bug: 404478371 Change-Id: Ic94261f0bbcd29dc8f7a62097beb2e754d589522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6462513 Reviewed-by: Khushal Sagar <khushalsagar@chromium.org> Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1450720}
diff --git a/css/css-view-transitions/empty-render-target-capture-ref.html b/css/css-view-transitions/empty-render-target-capture-ref.html
@@ -0,0 +1,23 @@
+<!DOCTYPE html>
+<html>
+<title>View transitions: empty render surface capture (ref)</title>
+<link rel="help" href="https://drafts.csswg.org/css-view-transitions-1/">
+<link rel="author" href="mailto:vmpstr@chromium.org">
+<style>
+
+.container {
+  width: 0px;
+  height: 0px;
+}
+.child {
+  width: 100px;
+  height: 100px;
+  background: green;
+  will-change: opacity;
+}
+
+</style>
+
+<div class=container>
+  <div class=child></div>
+</div>
diff --git a/css/css-view-transitions/empty-render-target-capture.html b/css/css-view-transitions/empty-render-target-capture.html
@@ -0,0 +1,49 @@
+<!DOCTYPE html>
+<html class=reftest-wait>
+<title>View transitions: empty render surface capture</title>
+<link rel="help" href="https://drafts.csswg.org/css-view-transitions-1/">
+<link rel="author" href="mailto:vmpstr@chromium.org">
+<link rel="match" href="empty-render-target-capture-ref.html">
+<script src="/common/reftest-wait.js"></script>
+<script src="/dom/events/scrolling/scroll_support.js"></script>
+<style>
+
+:root {
+  view-transition-name: none;
+}
+.container {
+  view-transition-name: container;
+  width: 0px;
+  height: 0px;
+}
+.child {
+  view-transition-name: child;
+  width: 100px;
+  height: 100px;
+  background: green;
+  will-change: opacity;
+}
+
+::view-transition-group(*),
+::view-transition-image-pair(*),
+::view-transition-old(*),
+::view-transition-new(*) {
+  animation-play-state: paused;
+}
+</style>
+
+<div class=container>
+  <div class=child></div>
+</div>
+
+<script>
+function runTest() {
+  document.startViewTransition().ready.then(takeScreenshot);
+}
+
+onload = async () => {
+  await waitForCompositorReady();
+  runTest();
+}
+
+</script>
