fix: banner shouldn't be injected to asset (#3809)

* chore: banner shouldn't be injected to asset

* fix:  distinguish auxiliaryFiles and files

* fix: add auxiliaryFiles to stats

---------

Co-authored-by: gaoyuan.1226 <[email protected]>

Author: hardfist

crates/node_binding/binding.d.ts

@@ -305,6 +305,7 @@ export interface JsStatsAssetsByChunkName {
 export interface JsStatsChunk {
   type: string
   files: Array<string>
+  auxiliaryFiles: Array<string>
   id: string
   entry: boolean
   initial: boolean

crates/node_binding/src/js_values/stats.rs

@@ -180,6 +180,7 @@ impl From<rspack_core::StatsModuleReason> for JsStatsModuleReason {
 pub struct JsStatsChunk {
   pub r#type: &'static str,
   pub files: Vec<String>,
+  pub auxiliary_files: Vec<String>,
   pub id: String,
   pub entry: bool,
   pub initial: bool,
@@ -197,6 +198,7 @@ impl TryFrom<rspack_core::StatsChunk<'_>> for JsStatsChunk {
     Ok(Self {
       r#type: stats.r#type,
       files: stats.files,
+      auxiliary_files: stats.auxiliary_files,
       id: stats.id,
       entry: stats.entry,
       initial: stats.initial,

crates/rspack_core/src/chunk.rs

@@ -30,6 +30,7 @@ pub struct Chunk {
   pub ids: Vec<String>,
   pub id_name_hints: HashSet<String>,
   pub files: HashSet<String>,
+  pub auxiliary_files: HashSet<String>,
   pub groups: HashSet<ChunkGroupUkey>,
   pub runtime: RuntimeSpec,
   pub kind: ChunkKind,
@@ -56,6 +57,7 @@ impl Chunk {
       ids: vec![],
       id_name_hints: Default::default(),
       files: Default::default(),
+      auxiliary_files: Default::default(),
       groups: Default::default(),
       runtime: HashSet::default(),
       kind,

crates/rspack_core/src/compiler/compilation.rs

@@ -236,6 +236,7 @@ impl Compilation {
       }
       self.chunk_by_ukey.iter_mut().for_each(|(_, chunk)| {
         chunk.files.remove(filename);
+        chunk.auxiliary_files.remove(filename);
       });
     }
   }
@@ -247,6 +248,10 @@ impl Compilation {
         if chunk.files.remove(filename) {
           chunk.files.insert(new_name.clone());
         }
+
+        if chunk.auxiliary_files.remove(filename) {
+          chunk.auxiliary_files.insert(new_name.clone());
+        }
       });
     }
   }
@@ -920,7 +925,12 @@ impl Compilation {
           .chunk_by_ukey
           .get_mut(&chunk_ukey)
           .unwrap_or_else(|| panic!("chunk({chunk_ukey:?}) should be in chunk_by_ukey",));
-        current_chunk.files.insert(filename.clone());
+
+        if file_manifest.auxiliary {
+          current_chunk.auxiliary_files.insert(filename.clone());
+        } else {
+          current_chunk.files.insert(filename.clone());
+        }
 
         self.emit_asset(
           filename.clone(),

crates/rspack_core/src/plugin/api.rs

@@ -414,15 +414,16 @@ pub struct RenderManifestEntry {
   pub(crate) info: AssetInfo,
   // pub identifier: String,
   // hash?: string;
-  // auxiliary?: boolean;
+  pub(crate) auxiliary: bool,
 }
 
 impl RenderManifestEntry {
-  pub fn new(source: BoxSource, filename: String, info: AssetInfo) -> Self {
+  pub fn new(source: BoxSource, filename: String, info: AssetInfo, auxiliary: bool) -> Self {
     Self {
       source,
       filename,
       info,
+      auxiliary,
     }
   }
 

crates/rspack_core/src/stats.rs

@@ -43,6 +43,11 @@ impl Stats<'_> {
         let chunks = compilation_file_to_chunks.entry(file).or_default();
         chunks.push(chunk);
       }
+
+      for file in &chunk.auxiliary_files {
+        let chunks = compilation_file_to_chunks.entry(file).or_default();
+        chunks.push(chunk);
+      }
     }
 
     let mut assets: HashMap<&String, StatsAsset> = HashMap::from_iter(
@@ -157,6 +162,10 @@ impl Stats<'_> {
       .map(|c| -> Result<_> {
         let mut files = Vec::from_iter(c.files.iter().cloned());
         files.sort_unstable();
+
+        let mut auxiliary_files = Vec::from_iter(c.auxiliary_files.iter().cloned());
+        auxiliary_files.sort_unstable();
+
         let chunk_modules = if chunk_modules {
           let chunk_modules = self
             .compilation
@@ -181,6 +190,7 @@ impl Stats<'_> {
         Ok(StatsChunk {
           r#type: "chunk",
           files,
+          auxiliary_files,
           id: c.expect_id().to_string(),
           names: c.name.clone().map(|n| vec![n]).unwrap_or_default(),
           entry: c.has_entry_module(&self.compilation.chunk_graph),
@@ -540,6 +550,7 @@ pub struct StatsModule<'a> {
 pub struct StatsChunk<'a> {
   pub r#type: &'static str,
   pub files: Vec<String>,
+  pub auxiliary_files: Vec<String>,
   pub id: String,
   pub entry: bool,
   pub initial: bool,

crates/rspack_plugin_asset/src/lib.rs

@@ -542,7 +542,12 @@ impl Plugin for AssetPlugin {
               .get::<CodeGenerationDataAssetInfo>()
               .expect("should have asset_info")
               .inner();
-            RenderManifestEntry::new(source, asset_filename.to_owned(), asset_info.to_owned())
+            RenderManifestEntry::new(
+              source,
+              asset_filename.to_owned(),
+              asset_info.to_owned(),
+              true,
+            )
           });
 
         Ok(result)

crates/rspack_plugin_css/src/plugin/impl_plugin_for_css_plugin.rs

@@ -245,6 +245,7 @@ impl Plugin for CssPlugin {
       source.boxed(),
       output_path,
       asset_info,
+      false,
     )])
   }
 

crates/rspack_plugin_devtool/src/lib.rs

@@ -1,5 +1,6 @@
 #![feature(let_chains)]
 
+use std::collections::HashSet;
 use std::{hash::Hash, path::Path};
 
 use dashmap::DashMap;
@@ -176,14 +177,19 @@ impl Plugin for DevtoolPlugin {
           .boxed(),
         );
         args.compilation.emit_asset(filename, asset);
+        // TODO
+        // chunk.auxiliary_files.add(filename);
       } else {
         let mut source_map_filename = filename.to_owned() + ".map";
         // TODO(ahabhgk): refactor remove the for loop
         // https://webpack.docschina.org/configuration/output/#outputsourcemapfilename
         if args.compilation.options.devtool.source_map() {
           let source_map_filename_config = &args.compilation.options.output.source_map_filename;
           for chunk in args.compilation.chunk_by_ukey.values() {
-            for file in &chunk.files {
+            let files: HashSet<String> =
+              chunk.files.union(&chunk.auxiliary_files).cloned().collect();
+
+            for file in &files {
               if file == &filename {
                 let source_type = if is_css {
                   &SourceType::Css

crates/rspack_plugin_javascript/src/plugin/impl_plugin_for_js_plugin.rs

@@ -181,6 +181,7 @@ impl Plugin for JsPlugin {
       source,
       output_path,
       asset_info,
+      false,
     )])
   }
 

crates/rspack_plugin_wasm/src/wasm_plugin.rs

@@ -83,7 +83,7 @@ impl Plugin for AsyncWasmPlugin {
               .get(&m.identifier())
               .map(|s| s.clone())
               .expect("should have wasm_filename");
-            RenderManifestEntry::new(source, output_path, asset_info)
+            RenderManifestEntry::new(source, output_path, asset_info, false)
           });
 
         Ok(result)

packages/rspack/tests/Stats.test.ts

@@ -50,6 +50,7 @@ describe("Stats", () => {
 		  },
 		  "chunks": [
 		    {
+		      "auxiliaryFiles": [],
 		      "children": [],
 		      "entry": true,
 		      "files": [