Skip to content

Commit f46f5da

Browse files
committed
Update dev-resources to match review comments
- Resource alphabetical ordering - fix `-f` to become `-k` as otherwise specified (muscle memory) - split monitoring namespace to earlier in kustomize tree - drop `targetNamespace` from monitoring - podinfo targetNamespace remains as this enforces namespace to resources that do not have it set in upstream repo
1 parent 3e760fe commit f46f5da

13 files changed

+32
-27
lines changed

doc/development-process.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ Woop! It's working. It'll be empty cos you haven't created any flux objects. You
8383

8484
To help see some objects in the UI lets create some sample sources, run the following:
8585

86-
`$ k apply -f ./tools/dev-resources`
86+
`$ k apply -k ./tools/dev-resources`
8787

8888
Boom! You'll see our newly created flux objects in the UI.
8989

tools/dev-resources/README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,9 @@ This directory contains quickstart resources to help get going with Weave-GitOps
55
Apply the contents of this directory to your cluster with
66

77
`$ k apply -k .`
8+
9+
> [!Note]
10+
> ImageUpdateAutomation will fail as it points to a non-existing GitRepository
11+
>
12+
> You're welcome to create that repository, or use it as a failure case to test
13+
> error state in the UI.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
resources:
22
- podinfo-image-policy.yaml
3+
- podinfo-image-repository.yaml
34
- podinfo-image-update-automation.yaml
4-
- podinfo-image-repository.yaml

tools/dev-resources/image-policy/podinfo-image-policy.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: image.toolkit.fluxcd.io/v1beta2
22
kind: ImagePolicy
33
metadata:
44
name: podinfo
5-
namespace: flux-system
5+
namespace: default
66
spec:
77
imageRepositoryRef:
88
name: podinfo

tools/dev-resources/image-policy/podinfo-image-repository.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: image.toolkit.fluxcd.io/v1beta2
22
kind: ImageRepository
33
metadata:
44
name: podinfo
5-
namespace: flux-system
5+
namespace: default
66
spec:
77
image: ghcr.io/stefanprodan/podinfo
88
interval: 5m

tools/dev-resources/image-policy/podinfo-image-update-automation.yaml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
apiVersion: image.toolkit.fluxcd.io/v1beta2
22
kind: ImageUpdateAutomation
33
metadata:
4-
name: flux-system
5-
namespace: flux-system
4+
name: podinfo
5+
namespace: default
66
spec:
77
interval: 30m
88
sourceRef:
99
kind: GitRepository
1010
name: flux-system
11+
namespace: flux-system
1112
git:
1213
checkout:
1314
ref:
@@ -22,5 +23,3 @@ spec:
2223
update:
2324
path: ./clusters/management
2425
strategy: Setters
25-
26-
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
resources:
2-
- podinfo
32
- image-policy
4-
- monitoring
3+
- monitoring
4+
- namespace.yaml
5+
- podinfo
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
resources:
2-
- monitoring.yaml
2+
- monitoring.yaml
Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,54 @@
1+
---
12
apiVersion: source.toolkit.fluxcd.io/v1
23
kind: GitRepository
34
metadata:
45
name: flux-monitoring
5-
namespace: flux-system
6+
namespace: monitoring
67
spec:
78
interval: 10m0s
89
ref:
910
branch: main
1011
url: https://github.com/fluxcd/flux2-monitoring-example
1112
---
12-
apiVersion: v1
13-
kind: Namespace
14-
metadata:
15-
name: monitoring
16-
---
1713
apiVersion: kustomize.toolkit.fluxcd.io/v1
1814
kind: Kustomization
1915
metadata:
2016
name: kube-prometheus-stack
21-
namespace: flux-system
17+
namespace: monitoring
2218
spec:
2319
interval: 10m0s
2420
sourceRef:
2521
kind: GitRepository
2622
name: flux-monitoring
2723
path: ./monitoring/controllers/kube-prometheus-stack
2824
prune: true
29-
targetNamespace: monitoring
3025
wait: true
3126
---
3227
apiVersion: kustomize.toolkit.fluxcd.io/v1
3328
kind: Kustomization
3429
metadata:
3530
name: loki-stack
36-
namespace: flux-system
31+
namespace: monitoring
3732
spec:
3833
interval: 10m0s
3934
sourceRef:
4035
kind: GitRepository
4136
name: flux-monitoring
4237
path: ./monitoring/controllers/loki-stack
4338
prune: true
44-
targetNamespace: monitoring
4539
wait: true
4640
---
4741
apiVersion: kustomize.toolkit.fluxcd.io/v1
4842
kind: Kustomization
4943
metadata:
5044
name: monitoring-config
51-
namespace: flux-system
45+
namespace: monitoring
5246
spec:
5347
interval: 1m0s
5448
sourceRef:
5549
kind: GitRepository
56-
name: flux-monitoring
50+
name: monitoring
5751
path: ./monitoring/configs
5852
dependsOn:
5953
- name: kube-prometheus-stack
6054
prune: true
61-
targetNamespace: monitoring

tools/dev-resources/namespace.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
apiVersion: v1
3+
kind: Namespace
4+
metadata:
5+
name: monitoring
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
resources:
2+
- kustomize.yaml
23
- source.yaml
3-
- kustomize.yaml

tools/dev-resources/podinfo/kustomize.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,13 @@ apiVersion: kustomize.toolkit.fluxcd.io/v1
33
kind: Kustomization
44
metadata:
55
name: podinfo
6-
namespace: flux-system
6+
namespace: default
77
spec:
88
interval: 5m0s
99
path: ./kustomize
1010
prune: true
1111
sourceRef:
1212
kind: GitRepository
1313
name: podinfo
14+
namespace: default
1415
targetNamespace: default

tools/dev-resources/podinfo/source.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: source.toolkit.fluxcd.io/v1
33
kind: GitRepository
44
metadata:
55
name: podinfo
6-
namespace: flux-system
6+
namespace: default
77
spec:
88
interval: 30m0s
99
ref:

0 commit comments

Comments
 (0)