Skip to content

Commit 1fa3f9f

Browse files
authored
Merge pull request #221 from weaveworks/allow-blank-network
Allow blank network in server.New
2 parents 284892f + 2357985 commit 1fa3f9f

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

server/server.go

+10-2
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,12 @@ func New(cfg Config) (*Server, error) {
171171
}, []string{"protocol"})
172172
prometheus.MustRegister(tcpConnections)
173173

174+
network := cfg.HTTPListenNetwork
175+
if network == "" {
176+
network = DefaultNetwork
177+
}
174178
// Setup listeners first, so we can fail early if the port is in use.
175-
httpListener, err := net.Listen(cfg.HTTPListenNetwork, fmt.Sprintf("%s:%d", cfg.HTTPListenAddress, cfg.HTTPListenPort))
179+
httpListener, err := net.Listen(network, fmt.Sprintf("%s:%d", cfg.HTTPListenAddress, cfg.HTTPListenPort))
176180
if err != nil {
177181
return nil, err
178182
}
@@ -182,7 +186,11 @@ func New(cfg Config) (*Server, error) {
182186
httpListener = netutil.LimitListener(httpListener, cfg.HTTPConnLimit)
183187
}
184188

185-
grpcListener, err := net.Listen(cfg.HTTPListenNetwork, fmt.Sprintf("%s:%d", cfg.GRPCListenAddress, cfg.GRPCListenPort))
189+
network = cfg.GRPCListenNetwork
190+
if network == "" {
191+
network = DefaultNetwork
192+
}
193+
grpcListener, err := net.Listen(network, fmt.Sprintf("%s:%d", cfg.GRPCListenAddress, cfg.GRPCListenPort))
186194
if err != nil {
187195
return nil, err
188196
}

0 commit comments

Comments
 (0)