change: remove wazuh_core.hosts settings

Desvelao · Desvelao · commit e3d0b4f8c735 · 2025-03-11T15:27:40.000+01:00
- Remove wazuh_core.hosts settings
- Removed initiation of ManageHosts and ServerAPIClient in the server
  side
- Removed server API client exposed through the wazuh_core plugin in the
  plugin lifecycle methods
- Disconnected/mocked some services to allow the plugins does not fail
diff --git a/docker/osd-dev/config/2.x/osd/opensearch_dashboards.yml b/docker/osd-dev/config/2.x/osd/opensearch_dashboards.yml
@@ -19,10 +19,3 @@ opensearch.username: 'kibanaserver'
 opensearch.password: 'kibanaserver'
 opensearchDashboards.branding:
   useExpandedHeader: false
-wazuh_core.hosts:
-  manager:
-    url: 'https://wazuh.manager'
-    port: 55000
-    username: wazuh-wui
-    password: MyS3cr37P450r.*-
-    run_as: false
diff --git a/plugins/wazuh-core/common/constants.ts b/plugins/wazuh-core/common/constants.ts
@@ -621,115 +621,6 @@ export const PLUGIN_SETTINGS: Record<string, TPluginSetting> = {
     defaultValue: false,
     validate: SettingsValidator.isBoolean,
   },
-  /* `# The following configuration is the default structure to define a host.
-#
-# hosts:
-#   # Host ID / name,
-#   - env-1:
-#       # Host URL
-#       url: https://env-1.example
-#       # Host / API port
-#       port: 55000
-#       # Host / API username
-#       username: wazuh-wui
-#       # Host / API password
-#       password: wazuh-wui
-#       # Use RBAC or not. If set to true, the username must be "wazuh-wui".
-#       run_as: true
-#   - env-2:
-#       url: https://env-2.example
-#       port: 55000
-#       username: wazuh-wui
-#       password: wazuh-wui
-#       run_as: true
-
-hosts:
-  - default:
-      url: https://localhost
-      port: 55000
-      username: wazuh-wui
-      password: wazuh-wui
-      run_as: false`,
-  */
-  hosts: {
-    title: 'Server hosts',
-    description: 'Configure the API connections.',
-    source: EConfigurationProviders.INITIALIZER_CONTEXT,
-    category: SettingCategory.API_CONNECTION,
-    type: EpluginSettingType.objectOf,
-    defaultValue: [],
-    options: {
-      objectOf: {
-        url: {
-          title: 'URL',
-          description: 'Server URL address',
-          type: EpluginSettingType.text,
-          defaultValue: 'https://localhost',
-          validate: SettingsValidator.compose(
-            SettingsValidator.isString,
-            SettingsValidator.isNotEmptyString,
-          ),
-        },
-        port: {
-          title: 'Port',
-          description: 'Port',
-          type: EpluginSettingType.number,
-          defaultValue: 55000,
-          options: {
-            number: {
-              min: 0,
-              max: 65535,
-              integer: true,
-            },
-          },
-          validate: function (value) {
-            return SettingsValidator.number(this.options?.number)(value);
-          },
-        },
-        username: {
-          title: 'Username',
-          description: 'Server API username',
-          type: EpluginSettingType.text,
-          defaultValue: 'wazuh-wui',
-          validate: SettingsValidator.compose(
-            SettingsValidator.isString,
-            SettingsValidator.isNotEmptyString,
-          ),
-        },
-        password: {
-          title: 'Password',
-          description: "User's Password",
-          type: EpluginSettingType.password,
-          defaultValue: 'wazuh-wui',
-          validate: SettingsValidator.compose(
-            SettingsValidator.isString,
-            SettingsValidator.isNotEmptyString,
-          ),
-        },
-        run_as: {
-          title: 'Run as',
-          description: 'Use the authentication context.',
-          type: EpluginSettingType.switch,
-          defaultValue: false,
-          options: {
-            switch: {
-              values: {
-                disabled: { label: 'false', value: false },
-                enabled: { label: 'true', value: true },
-              },
-            },
-          },
-          validate: SettingsValidator.isBoolean,
-        },
-      },
-    },
-    isConfigurableFromSettings: false,
-    // TODO: add validation
-    // validate: SettingsValidator.isBoolean,
-    // validate: function (schema) {
-    //   return schema.boolean();
-    // },
-  },
   'ip.ignore': {
     title: 'Index pattern ignore',
     description:
diff --git a/plugins/wazuh-core/public/plugin.ts b/plugins/wazuh-core/public/plugin.ts
@@ -14,7 +14,6 @@ import { NoopLogger } from '../common/logger/noop-logger';
 import { WazuhCorePluginSetup, WazuhCorePluginStart } from './types';
 import { setChrome, setCore, setUiSettings } from './plugin-services';
 import { UISettingsConfigProvider } from './services/configuration/ui-settings-provider';
-import { InitializerConfigProvider } from './services/configuration/initializer-context-provider';
 import * as utils from './utils';
 import * as uiComponents from './components';
 import {
@@ -73,10 +72,11 @@ export class WazuhCorePlugin
 
     this.internal.configurationStore = new ConfigurationStore(logger);
 
-    this.internal.configurationStore.registerProvider(
-      EConfigurationProviders.INITIALIZER_CONTEXT,
-      new InitializerConfigProvider(this.initializerContext),
-    );
+    // Uncomment if there is at least one setting of "wazuh_core" plugin
+    // this.internal.configurationStore.registerProvider(
+    //   EConfigurationProviders.INITIALIZER_CONTEXT,
+    //   new InitializerConfigProvider(this.initializerContext),
+    // );
 
     // register the uiSettins on the configuration store to avoid the use inside of configuration service
     this.internal.configurationStore.registerProvider(
diff --git a/plugins/wazuh-core/server/index.ts b/plugins/wazuh-core/server/index.ts
@@ -1,10 +1,4 @@
-import { schema, TypeOf } from '@osd/config-schema';
-import {
-  PluginConfigDescriptor,
-  PluginInitializerContext,
-} from '../../../src/core/server';
-import { PLUGIN_SETTINGS } from '../common/constants';
-import { getConfigSettingsDefinitions } from '../common/settings-adapter';
+import { PluginInitializerContext } from '../../../src/core/server';
 import { WazuhCorePlugin } from './plugin';
 
 // This exports static code and TypeScript types,
@@ -14,17 +8,5 @@ export function plugin(initializerContext: PluginInitializerContext) {
   return new WazuhCorePlugin(initializerContext);
 }
 
-const initiliazerConfig = getConfigSettingsDefinitions(PLUGIN_SETTINGS);
-
-export const configSchema = schema.object(initiliazerConfig);
-export type CorePluginConfigType = TypeOf<typeof configSchema>;
-
-export const config: PluginConfigDescriptor<CorePluginConfigType> = {
-  exposeToBrowser: {
-    hosts: true,
-  },
-  schema: configSchema,
-};
-
 export type { WazuhCorePluginSetup, WazuhCorePluginStart } from './types';
 export * from './types';
diff --git a/plugins/wazuh-core/server/plugin.ts b/plugins/wazuh-core/server/plugin.ts
@@ -12,7 +12,6 @@ import {
   WAZUH_PLUGIN_PLATFORM_SETTING_MAX_BUCKETS,
   WAZUH_PLUGIN_PLATFORM_SETTING_METAFIELDS,
   WAZUH_PLUGIN_PLATFORM_SETTING_TIME_FILTER,
-  EConfigurationProviders,
   PLUGIN_SETTINGS,
 } from '../common/constants';
 import {
@@ -26,16 +25,9 @@ import {
   WazuhCorePluginStart,
 } from './types';
 import { setCore } from './plugin-services';
-import {
-  ManageHosts,
-  createDashboardSecurity,
-  ServerAPIClient,
-  InitializationService,
-} from './services';
+import { createDashboardSecurity, InitializationService } from './services';
 // configuration common
 // configuration server
-import { InitializerConfigProvider } from './services/configuration';
-import { initializationTaskCreatorServerAPIConnectionCompatibility } from './initialization/server-api';
 import {
   initializationTaskCreatorExistTemplate,
   initializationTaskCreatorIndexPattern,
@@ -86,10 +78,11 @@ export class WazuhCorePlugin
     );
 
     // add the initializer context config to the configuration store
-    this.internal.configurationStore.registerProvider(
-      EConfigurationProviders.PLUGIN_UI_SETTINGS,
-      new InitializerConfigProvider(this.initializerContext),
-    );
+    // Uncomment if there is at least one setting of "wazuh_core" plugin
+    // this.internal.configurationStore.registerProvider(
+    //   EConfigurationProviders.PLUGIN_UI_SETTINGS,
+    //   new InitializerConfigProvider(this.initializerContext),
+    // );
 
     // create the configuration service to use like a facede pattern
     this.services.configuration = new Configuration(
@@ -99,19 +92,6 @@ export class WazuhCorePlugin
 
     this.services.configuration.setup();
 
-    this.services.manageHosts = new ManageHosts(
-      this.logger.get('manage-hosts'),
-      this.services.configuration,
-    );
-
-    this.services.serverAPIClient = new ServerAPIClient(
-      this.logger.get('server-api-client'),
-      this.services.manageHosts,
-      this.services.dashboardSecurity,
-    );
-
-    this.services.manageHosts.setServerAPIClient(this.services.serverAPIClient);
-
     this.services.initialization = new InitializationService(
       this.logger.get('initialization'),
       this.services,
@@ -120,11 +100,12 @@ export class WazuhCorePlugin
     this.services.initialization.setup({ core });
 
     // Register initialization tasks
-    this.services.initialization.register(
-      initializationTaskCreatorServerAPIConnectionCompatibility({
-        taskName: 'check-server-api-connection-compatibility',
-      }),
-    );
+    // TODO: remove because the server API management is not used
+    // this.services.initialization.register(
+    //   initializationTaskCreatorServerAPIConnectionCompatibility({
+    //     taskName: 'check-server-api-connection-compatibility',
+    //   }),
+    // );
 
     // Index pattern: alerts
     // TODO: this task should be registered by the related plugin
@@ -337,25 +318,10 @@ export class WazuhCorePlugin
       logger: this.logger.get(
         `${request.route.method.toUpperCase()} ${request.route.path}`,
       ),
-      api: {
-        client: {
-          asInternalUser: this.services.serverAPIClient.asInternalUser,
-          asCurrentUser: this.services.serverAPIClient.asScoped(
-            context,
-            request,
-          ),
-        },
-      },
     }));
 
     return {
       ...this.services,
-      api: {
-        client: {
-          asInternalUser: this.services.serverAPIClient.asInternalUser,
-          asScoped: this.services.serverAPIClient.asScoped,
-        },
-      },
     } as WazuhCorePluginSetup;
   }
 
@@ -365,17 +331,10 @@ export class WazuhCorePlugin
     setCore(core);
 
     await this.services.configuration.start();
-    await this.services.manageHosts.start();
     await this.services.initialization.start({ core });
 
     return {
       ...this.services,
-      api: {
-        client: {
-          asInternalUser: this.services.serverAPIClient.asInternalUser,
-          asScoped: this.services.serverAPIClient.asScoped,
-        },
-      },
     } as WazuhCorePluginSetup;
   }
 
diff --git a/plugins/wazuh-core/server/types.ts b/plugins/wazuh-core/server/types.ts
@@ -1,27 +1,9 @@
-import {
-  ServerAPIInternalUserClient,
-  ServerAPIScopedUserClient,
-  WazuhCoreServices,
-} from './services';
+import { WazuhCoreServices } from './services';
 
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
-export interface WazuhCorePluginSetup extends WazuhCoreServices {
-  api: {
-    client: {
-      asInternalUser: ServerAPIInternalUserClient;
-      asScoped: (context: any, request: any) => ServerAPIScopedUserClient;
-    };
-  };
-}
+export interface WazuhCorePluginSetup extends WazuhCoreServices {}
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
-export interface WazuhCorePluginStart extends WazuhCoreServices {
-  api: {
-    client: {
-      asInternalUser: ServerAPIInternalUserClient;
-      asScoped: (context: any, request: any) => ServerAPIScopedUserClient;
-    };
-  };
-}
+export interface WazuhCorePluginStart extends WazuhCoreServices {}
 
 export interface PluginSetup {
   securityDashboards?: object; // TODO: Add OpenSearch Dashboards Security interface
