Skip to content

Various display settings configuration numeric fields do not save without explicitly pressing enter or tab which might be confusing #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HollowMan6 opened this issue Sep 7, 2024 · 5 comments
Assignees
Labels
bug Something isn't working done All tasks are completed released Released
Milestone

Comments

@HollowMan6
Copy link

As is shown in the GIF:
Sep-08-2024 01-55-03

Here, the height was automatically removed after I activated it without reboot. As a temporary workaround, I need to switch to a new tab and go back, so I guess it should be a front-end issue.

@waydabber
Copy link
Owner

waydabber commented Sep 8, 2024

Well, you need to press ENTER or TAB - when you see the "Invalid resolution (skipped)" text, it means the app will skip adding that resolution.

Btw what macOS version are you running? Interstingly the text in the red/orange box does not seem to appear properly. I am not sure why that is. It should look like this:

Screenshot 2024-09-08 at 10 08 20

UPDATE: Oh, I see, the window is set to be small vertically, that's why the text is compressed and the top menu moved under the traffic lights. I'll increase the minimum height a bit.

@HollowMan6 HollowMan6 changed the title New custom scaled resolution failed to activate when there's no previous ones New custom scaled resolution failed to activate without pressing enter Sep 8, 2024
@waydabber waydabber changed the title New custom scaled resolution failed to activate without pressing enter Settings menu bar may look bad when the window is set to minimum height and the display configuration prompt shown Sep 8, 2024
@waydabber waydabber added the bug Something isn't working label Sep 8, 2024
@waydabber
Copy link
Owner

Note: just checked the code, actually the field should save value when defocused. For whatever reason however it does not seem to work properly in some instances (the field does not defocus, even though the highlight goes away). The issue I face is that currently SwiftUI (Apple's new UI framework the app uses) does not provide a proper workaround I could use. I can try fixing this by adding an explicit "Update" or "Add" button maybe to avoid confusion, but that feels somewhat clunky. Will investigate this in the future more as I agree that the current way it works is somewhat unintuitive.

@HollowMan6 HollowMan6 changed the title Settings menu bar may look bad when the window is set to minimum height and the display configuration prompt shown Settings menu bar may look bad when the window is set to minimum height and the display configuration prompt shown | New custom scaled resolution failed to activate without pressing enter Sep 8, 2024
@waydabber waydabber changed the title Settings menu bar may look bad when the window is set to minimum height and the display configuration prompt shown | New custom scaled resolution failed to activate without pressing enter New custom scaled resolution failed to activate without pressing enter Sep 8, 2024
@waydabber waydabber self-assigned this Sep 8, 2024
@waydabber waydabber added done All tasks are completed internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels Sep 8, 2024
@waydabber waydabber added this to the v3.0.6 milestone Sep 8, 2024
@waydabber
Copy link
Owner

I just changed it so the field is submitted after each keypress. That should work (unless the user decides to abandon things midway, that might cause obvious problems).

@waydabber
Copy link
Owner

(separated the menu Settings menu bar stuff to a different issue #3375)

@waydabber waydabber changed the title New custom scaled resolution failed to activate without pressing enter Various display settings configuration numeric fields do not save without explicitly pressing enter or tab which might be confusing Sep 8, 2024
@waydabber
Copy link
Owner

The issue actually affects all other fields similarly so changed the behavior of all.

@waydabber waydabber added pre-release available Released as beta version and removed internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels Oct 1, 2024
@waydabber waydabber added released Released and removed pre-release available Released as beta version labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done All tasks are completed released Released
Projects
None yet
Development

No branches or pull requests

2 participants