Skip to content

Seemingly Duplicate Resolutions In Set Resolution Menu by default on Intel #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
khalidabuhakmeh opened this issue Mar 8, 2023 · 7 comments
Assignees
Labels
bug Something isn't working done All tasks are completed Intel Related to Macs with Intel architecture released Released
Milestone

Comments

@khalidabuhakmeh
Copy link

khalidabuhakmeh commented Mar 8, 2023

👋 Hello,

I'm a BetterDisplay Pro user, and I love the product.

I noticed that I see duplicate resolutions when I go to the Set Resolution menu. Please take a look at the image below.

Screenshot 2023-03-08 at 16 18 12

I also included the About page here.

Screenshot 2023-03-08 at 16 21 45

@waydabber
Copy link
Owner

Hmm. Indeed. This is not how it should work. Can you enable these and create a screenshot? That should give a bit more info about these resolutions that would be helpful for me. Thank you!

Screenshot 2023-03-08 at 22 46 39

@waydabber waydabber added the investigating Investigating issue label Mar 8, 2023
@waydabber
Copy link
Owner

No worries, I was able to reproduce the issue on my Intel test machine! Thanks for reporting!

@waydabber waydabber added bug Something isn't working in progress Implementing internal pre-release Enable internal pre-releases under Settings/Applications/Updates and removed investigating Investigating issue labels Mar 9, 2023
@waydabber waydabber self-assigned this Mar 9, 2023
@waydabber waydabber added this to the v1.4.6 milestone Mar 9, 2023
@waydabber waydabber added the Intel Related to Macs with Intel architecture label Mar 9, 2023
@waydabber waydabber changed the title Seemingly Duplicate Resolutions In Set Resolution Menu Seemingly Duplicate Resolutions In Set Resolution Menu by default on Intel Mar 9, 2023
@waydabber
Copy link
Owner

All right, fixed it, will be in the next resase. The problem was the multiple bit-depth options on Intel which caused a duplication.

Sorry about this!

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels Mar 9, 2023
@khalidabuhakmeh
Copy link
Author

No worries. I love this product. I am happy you found the issue and that I could help. Keep up the great work.

@waydabber
Copy link
Owner

I'll just keep this one open until I release the updated version so I don't forget to include it in the release notes. :)

@waydabber waydabber added released Released and removed internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels Mar 13, 2023
@joevt
Copy link

joevt commented Mar 13, 2023

The bit depth in a CGDisplayMode refers to the frame buffer bit depth (where you can switch between 8 and 10bpc). Note that the two modes (with different mode index) both have the same modeID. The modeID points to a DetailedTimingInformation structure (found in ioreg) that describes the actual timing and the output color encoding and bit depth (for modern GPUs). The frame buffer bit depth and the output color encoding and bit depth don't need to match (and of course at least one of the frame buffer bit depth values won't match). The frame buffer is usually RGB but the output may be YCbCr (like for HDMI displays).

@waydabber
Copy link
Owner

Yes, the app handles the differing frame buffer bit depths (there is a 'Color Depth' submenu for that on Intel), the duplication of resolutions due to this in the 'Set Resolution' menu was an oversight on my part as I mostly test my app on Apple Silicon where only a single framebuffer bit depth is offered in practice - at least I never saw anything else (normally the Set Resolution menu should list resolution alternatives only for the current bit depth and refresh rate - except if it is set to show everything under Settings/App Menu, but then it properly lists bit depth differences in the list as well).

BD currently does not detect or differentiate at all based on output color encoding - neither on Intel (where it would be technically possible), nor on Apple Silicon (where the method is unknown, but see the other post on how one could probably get that info as part of a more proper link description which should probably match in content with the LinkDescription key in the windowserver display config, but it's just a guess, did not go after it yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done All tasks are completed Intel Related to Macs with Intel architecture released Released
Projects
None yet
Development

No branches or pull requests

3 participants