Skip to content

Make config protection more adamant - do not update protection settings on config protection induced resolution change #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zorast opened this issue Mar 5, 2023 · 3 comments
Closed

Make config protection more adamant - do not update protection settings on config protection induced resolution change #1614

Zorast opened this issue Mar 5, 2023 · 3 comments
Assignees
@waydabber
Labels
done All tasks are completed enhancement New feature or request released Released
Milestone
v1.4.5

Comments

@Zorast
Copy link

Zorast commented Mar 5, 2023

Config protection does not enable 4k@120hz after EDID override with change to DP-Transportstream.
I also test to change the default resolution to 4k @ 120hz.
@Zorast Zorast changed the title Config Protection does not enable 4k@120hz when apply ne EDID Config Protection does not enable 4k@120hz when apply new EDID Mar 5, 2023
@waydabber waydabber added the investigating Investigating issue label Mar 6, 2023
@waydabber
Copy link
Owner

Can you show the protection menu's screenshot so I see how it is set up? Thanks!

@waydabber waydabber changed the title Config Protection does not enable 4k@120hz when apply new EDID Make config protection a bit more adamant - do not update protection settings on config protection induced resolution change Mar 6, 2023
@waydabber waydabber added enhancement New feature or request and removed investigating Investigating issue labels Mar 6, 2023
@waydabber waydabber self-assigned this Mar 6, 2023
@waydabber waydabber added this to the v1.4.5 milestone Mar 6, 2023
@waydabber waydabber added done All tasks are completed internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels Mar 6, 2023
@waydabber
Copy link
Owner

I tweaked the config protection in a way that it does not save resolution data as a new config protection target if it does not find an optimal resolution to begin with. I tried switching between a 60Hz-only and 120Hz only EDID and I could not reproduce the issue, but with an EDID that has 120Hz just not at the protected resolution I found the app defaulted to a suboptional 120Hz resolution which might have caused this (?). We'll see in v1.4.5. If you want I can post a test version to try.

@Zorast
Copy link
Author

Zorast commented Mar 6, 2023

ok nice, I will test this !

@waydabber waydabber changed the title Make config protection a bit more adamant - do not update protection settings on config protection induced resolution change Make config protection more adamant - do not update protection settings on config protection induced resolution change Mar 7, 2023
@waydabber waydabber added pre-release available Released as beta version and removed internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels Mar 7, 2023
@waydabber waydabber added released Released and removed pre-release available Released as beta version labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waydabber waydabber

Labels
done All tasks are completed enhancement New feature or request released Released
Projects
None yet
Milestone
v1.4.5
Development

No branches or pull requests
2 participants
@waydabber @Zorast