Skip to content

GUI: Redesign display headers with a power button for connect/disconnect #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
waydabber opened this issue Jan 29, 2023 · 6 comments
Closed

GUI: Redesign display headers with a power button for connect/disconnect #1422

waydabber opened this issue Jan 29, 2023 · 6 comments
Assignees
@waydabber
Labels
DDC DDC related issue display connection Display connection management done All tasks are completed enhancement New feature or request released Released
Milestone
v1.4.1

Comments

@waydabber
Copy link
Owner

waydabber commented Jan 29, 2023 •
edited
Loading

The current connect/disconnect menu item is somewhat ugly/unprofessional.

Screenshot 2023-01-29 at 18 39 52
@waydabber waydabber added the enhancement New feature or request label Jan 29, 2023
@waydabber waydabber added this to the v1.4.1 milestone Jan 29, 2023
@waydabber waydabber added the display connection Display connection management label Jan 29, 2023
@waydabber waydabber self-assigned this Jan 30, 2023
@waydabber waydabber added DDC DDC related issue in progress Implementing internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels Jan 31, 2023
@waydabber waydabber mentioned this issue Feb 3, 2023
Closed
@waydabber
Copy link
Owner Author

Screenshot 2023-02-03 at 18 56 50

@waydabber
Copy link
Owner Author

Screenshot 2023-02-03 at 23 04 34

@waydabber waydabber added done All tasks are completed and removed in progress Implementing labels Feb 3, 2023
@waydabber waydabber changed the title Redesign display headers with a power button for connect/disconnect GUI: Redesign display headers with a power button for connect/disconnect Feb 5, 2023
@waydabber waydabber added pre-release available Released as beta version and removed internal pre-release Enable internal pre-releases under Settings/Applications/Updates labels Feb 5, 2023
@KrzysztofPrzygoda
Copy link

KrzysztofPrzygoda commented Feb 6, 2023 •
edited
Loading

Could you change the power button background in ON state to white?
This would be more meaningful than dark. Right now is hard to say which is which state with dark and empty background.

@waydabber
Copy link
Owner Author

I'll add an option to turn off hierarchical rendering for the header - that should give more contrast.

@waydabber
Copy link
Owner Author

Or I am not sure. It is not actually dark and white but empty vs filled - in dark mode this looks the other way around. How this looks is the default hierarchical rendering for this icon with the filled/nonfilled variants. I think the users will have to adapt to figuring it out which is which since no matter what I do unless I change the off icon to something completely different, there might be ambiguity. I could create an entirely custom flip icon with an explicit OFF and ON text on it as an alternative.

@waydabber
Copy link
Owner Author

Anyway: #1464

@waydabber waydabber added released Released and removed pre-release available Released as beta version labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waydabber waydabber

Labels
DDC DDC related issue display connection Display connection management done All tasks are completed enhancement New feature or request released Released
Projects
None yet
Milestone
v1.4.1
Development

No branches or pull requests
2 participants
@KrzysztofPrzygoda @waydabber