-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Provide workspace configs for text editors #2785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related to #2736 (we can also add prettier formatting) |
Formatters and environment are different problems though. I can't see us running GHCup inside a VS Code configuration right? (If it's even possible?) |
More about pointing haskell to right binaries, since user might have multiple versions installed, and might not have our version in path as default. e.g. {
"haskell.manageHLS": "GHCup",
"haskell.toolchain": {
"hls": "1.8.0.0"
},
} Users can always override these settings, if needed. |
No, they can't though. If I modify my User preferences, the workspace ones will take precedence. If I modify the Workspace preferences, this will show up as a modified file in git. |
That's what I meant, this configuration files should follow how we specify to set up the environment in our If they are deviating I don't see it a problem that they have it as an modified file in git. |
I don't agree 😅 I think each environment's setup (especially if only related to a single IDE) is a local workstation concern and not one that should be stored in the repo (moreover if it's going to override my User preferences). For reference I have my haskell setup through mise and not through GHCup. Git would keep bothering me to stash the config file or whatever. |
That is a good point. How about limiting the scope to what is actually done on workspace level, rather than tampering with global configuration? |
My preference would be to not add any settings for the environment at all (e.g. |
I haven't read everything, I would just be careful that we don't spend too much time here on somethign that at the end won't work for everybody. On one hand, having clear instructions in README on what to install is maybe the best -> they can follow that easily and all is good. It will depend on the specifics of the implementation here, I am just saying, I wouldn't push this too far -> if we can get something very practical very easily, great, if not, manual instructions are probably good enough. |
Uh oh!
There was an error while loading. Please reload this page.
Currently, it takes a bit of configuration to get all tooling around wasp working.
Especially around Haskell whose tooling is less supported by text editors.
We should provide config files for often used text edits which would solve above problems.
e.g.
.vscode
for VSCEven better if they could include recommendations for all extensions needed to work with wasp normally.
e.g.
.vscode\extensions.json
for VSCThis would solve issues around:
ormolu
for Haskell, which is not default)ormolu
binary)GHCup
)wasp.server.executable
which allows it to grab AppSpec from local development version of binary, which is necessary to test any AppSpec changes with wasp extension for VSCTODO: any more issues solved by this?
TODO: which text editors to support? should each be it's own issue with this being an parent issue?
The text was updated successfully, but these errors were encountered: