Skip to content

Refactor custom domain API in the deploy package #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
infomiho opened this issue May 21, 2025 · 0 comments
Open

Refactor custom domain API in the deploy package #2783

infomiho opened this issue May 21, 2025 · 0 comments
Labels
deployment refactoring Keeping that code clean!

Comments

@infomiho
Copy link
Contributor

Based on #2578 (comment)

We should probably revisit the way we handle custom domains when users deploy their apps with Wasp CLI.

Users can define a REACT_APP_API_URL env variable that the Wasp CLI and the deploy package detect and use instead of the default {prefix}-client domain. That API feels little bit too low level in hindsight. It was a hotfix proposed by a community member who was blocked and we accepted it.

We should think about the API and see if we can come up with something better.

@infomiho infomiho added refactoring Keeping that code clean! deployment labels May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment refactoring Keeping that code clean!
Projects
None yet
Development

No branches or pull requests

1 participant