Skip to content

[BUG] Empty metadata.annotations passes validation #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikenikles opened this issue May 28, 2025 · 1 comment
Open

[BUG] Empty metadata.annotations passes validation #676

mikenikles opened this issue May 28, 2025 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@mikenikles
Copy link

mikenikles commented May 28, 2025

I initially reported this at wasmCloud/wasmCloud#4481.

The following manifest passes validation, but fails at deploy time:

metadata:
  name: test
  annotations:

I was hoping that validate_manifest() (source) would report errors for the invalid manifest listed above.

@mikenikles mikenikles changed the title [BUG] Missing or incomplete metadata.annotations fails the deployment [BUG] Missing or incomplete metadata.annotations passes validation May 28, 2025
@mikenikles mikenikles changed the title [BUG] Missing or incomplete metadata.annotations passes validation [BUG] Empty metadata.annotations passes validation May 28, 2025
@brooksmtownsend
Copy link
Member

Oh yeah interesting @mikenikles , likely because we interpret that as an empty list of annotations which isn't technically an issue?

This is a bug and we should be able to fix this in the validate code 👍🏻

@brooksmtownsend brooksmtownsend added bug Something isn't working good first issue Good for newcomers labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants