Skip to content

feat: dogfood retry with one peer #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weboko opened this issue Sep 17, 2024 · 1 comment
Closed

feat: dogfood retry with one peer #2140

weboko opened this issue Sep 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Sep 17, 2024

This is a change request

Problem

Right now js-waku will attempt to retry sending message even if one success happened at the same time for the message:

void this.reliabilityMonitor.attemptRetriesOrRenew(

We are not sure of the benefit of having retry with at least one success. From PoV of protocol if LightPush returns success it is safe to assume that message was relayed further but since TWN has history of being unstable and we are not sure of the quality of community run nodes we should try and see if it is needed.

Proposed Solutions

Todo:

  1. Add telemetry for dogfooding app measuring successes / failures and delivery of message;
  2. Attempt retry only if LightPush to all redundant peers failed;
  3. Measure and save numbers;
  4. Change to attempting retry for all failures (even if some are successful);
  5. Measure and compare;

Notes

Discussion: link

@weboko weboko added the enhancement New feature or request label Sep 17, 2024
@weboko weboko added this to Waku Sep 17, 2024
@weboko weboko moved this to Priority in Waku Sep 17, 2024
@weboko weboko moved this from Priority to Done in Waku Mar 4, 2025
@weboko weboko self-assigned this Mar 4, 2025
@weboko
Copy link
Collaborator Author

weboko commented Mar 4, 2025

Was implemented in #2191

@weboko weboko closed this as completed Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

1 participant