Skip to content

feat(lightpush): add retries to failing peers #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danisharora099 opened this issue Jul 17, 2024 · 1 comment · Fixed by #2130
Closed

feat(lightpush): add retries to failing peers #2069

danisharora099 opened this issue Jul 17, 2024 · 1 comment · Fixed by #2130
Assignees

Comments

@danisharora099
Copy link
Collaborator

This is a feature request

Problem

For a LightPush send request, we push the message to multiple peers. If any of the peers fails to send the message, for whatever reason, we renew the peer with a new peer.
This is in contrast with the Reliability RFC, where we should instead attempt to retry before we renew.

Proposed Solutions

Retry the lightpush request with that peer before renewal

@fryorcraken fryorcraken added this to Waku Jul 17, 2024
@weboko weboko moved this to Triage in Waku Jul 17, 2024
@weboko weboko moved this from Triage to Priority in Waku Jul 18, 2024
@danisharora099
Copy link
Collaborator Author

To be done after #2075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant