Skip to content

chore: update release-please to 4 #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
weboko opened this issue Jul 13, 2024 · 1 comment · Fixed by #2305
Closed

chore: update release-please to 4 #2063

weboko opened this issue Jul 13, 2024 · 1 comment · Fixed by #2305
Assignees
@weboko
Labels
bug Something isn't working enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Jul 13, 2024 •
edited
Loading

This is a support request

Problem

We are using release-please of deprecated version and should transition to 4.
But it seems due to us using old version of release please the flag that bumps peer dependencies with regular is not enforced.

Last release it wasn't enforced for example - #2004

But for example in other projects with version 4 bump happens - https://github.com/launchdarkly/js-core/pull/418/files

Proposed Solutions

Move to newer version.
@fryorcraken fryorcraken added this to Waku Jul 13, 2024
@weboko weboko moved this to Triage in Waku Jul 13, 2024
@weboko weboko mentioned this issue Jul 13, 2024
Merged
@weboko weboko added bug Something isn't working enhancement New feature or request labels Jul 18, 2024
@weboko weboko moved this from Triage to To Do in Waku Jul 18, 2024
@weboko weboko moved this from To Do to In Progress in Waku Sep 5, 2024
@weboko weboko self-assigned this Sep 5, 2024
This was referenced Sep 5, 2024
Merged
Closed
@weboko
Copy link
Collaborator Author

weboko commented Oct 8, 2024

Not working on it now, prioritizing bug fixes for now.

@weboko weboko moved this from Code Review / QA to To Do in Waku Oct 8, 2024
@weboko weboko moved this from To Do to In Progress in Waku Mar 10, 2025
@weboko weboko moved this from In Progress to Code Review / QA in Waku Mar 17, 2025
@weboko weboko mentioned this issue Mar 17, 2025
Merged
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weboko weboko

Labels
bug Something isn't working enhancement New feature or request
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: up release-please waku-org/js-waku
1 participant
@weboko