feat: refactor discovery to use effect

Author: adklempner

package-lock.json

@@ -0,0 +1,17 @@
+# Ignore all test and example files in Effect directory
+src/effect/**/*.spec.ts
+src/effect/**/*.test.ts
+src/effect/**/test-*.ts
+src/effect/**/*-test.ts
+src/effect/**/*-example.ts
+src/effect/test-utils.ts
+src/effect/discovery-test.ts
+src/effect/minimal-test.ts
+src/effect/simple-test.ts
+src/effect/standalone-test.ts
+src/effect/working-example.ts
+src/effect/basic.spec.ts
+src/effect/cache.spec.ts
+src/effect/dns-discovery.spec.ts
+src/effect/integration.spec.ts
+src/effect/peer-exchange.spec.ts

packages/discovery/.eslintignore

@@ -1,6 +1,7 @@
 const config = {
   extension: ['ts'],
   spec: 'src/**/*.spec.ts',
+  ignore: 'src/effect/**/*.spec.ts',
   require: ['ts-node/register', 'isomorphic-fetch'],
   loader: 'ts-node/esm',
   'node-option': [

packages/discovery/.mocharc.cjs

@@ -51,34 +51,44 @@
     "node": ">=20"
   },
   "dependencies": {
-    "@waku/core": "0.0.35",
-    "@waku/enr": "0.0.29",
-    "@waku/interfaces": "0.0.30",
+    "@effect/platform": "^0.84.9",
+    "@effect/schema": "^0.75.5",
+    "@waku/core": "^0.0.35",
+    "@waku/enr": "^0.0.29",
+    "@waku/interfaces": "^0.0.30",
     "@waku/proto": "^0.0.10",
-    "@waku/utils": "0.0.23",
+    "@waku/utils": "^0.0.23",
     "debug": "^4.3.4",
     "dns-over-http-resolver": "^3.0.8",
+    "effect": "^3.16.5",
     "hi-base32": "^0.5.1",
     "uint8arrays": "^5.0.1"
   },
   "devDependencies": {
     "@libp2p/interface": "^2.1.3",
     "@libp2p/peer-id": "5.0.1",
+    "@libp2p/peer-id-factory": "^4.2.4",
+    "@libp2p/peer-store": "^11.2.3",
     "@multiformats/multiaddr": "^12.3.0",
     "@rollup/plugin-commonjs": "^25.0.7",
     "@rollup/plugin-json": "^6.0.0",
     "@rollup/plugin-node-resolve": "^15.2.3",
-    "@types/chai": "^4.3.11",
+    "@types/chai": "^4.3.20",
+    "@types/mocha": "^10.0.10",
     "@types/node-localstorage": "^1.3.3",
+    "@types/sinon": "^17.0.4",
     "@waku/build-utils": "*",
     "chai": "^4.3.10",
     "chai-as-promised": "^7.1.1",
     "cspell": "^8.6.1",
-    "mocha": "^10.3.0",
+    "datastore-core": "^10.0.4",
+    "mocha": "^10.8.2",
     "node-localstorage": "^3.0.5",
     "npm-run-all": "^4.1.5",
     "rollup": "^4.12.0",
-    "sinon": "^18.0.0"
+    "sinon": "^18.0.1",
+    "ts-node": "^10.9.2",
+    "tsx": "^4.20.2"
   },
   "files": [
     "dist",

packages/discovery/package.json

@@ -0,0 +1,35 @@
+import type { PeerDiscovery } from "@libp2p/interface";
+import type {
+  DnsDiscoveryComponents,
+  NodeCapabilityCount
+} from "@waku/interfaces";
+
+import { wakuDnsDiscoveryEffect } from "../effect/index.js";
+
+import { DEFAULT_NODE_REQUIREMENTS } from "./constants.js";
+import { wakuDnsDiscovery as wakuDnsDiscoveryPromise } from "./dns_discovery.js";
+
+/**
+ * Creates a DNS discovery instance with optional Effect support
+ *
+ * By default, uses the promise-based implementation for backward compatibility.
+ * Set WAKU_USE_EFFECT_DISCOVERY=true to use the Effect-based implementation.
+ *
+ * @param enrUrls - ENR tree URLs for discovery
+ * @param wantedNodeCapabilityCount - Required node capabilities
+ * @returns Factory function for creating discovery instance
+ */
+export function wakuDnsDiscoveryWithEffect(
+  enrUrls: string[],
+  wantedNodeCapabilityCount: Partial<NodeCapabilityCount> = DEFAULT_NODE_REQUIREMENTS
+): (components: DnsDiscoveryComponents) => PeerDiscovery {
+  // Check for feature flag
+  const useEffect = process.env.WAKU_USE_EFFECT_DISCOVERY === "true";
+
+  if (useEffect) {
+    // Using Effect-based implementation when WAKU_USE_EFFECT_DISCOVERY=true
+    return wakuDnsDiscoveryEffect(enrUrls, wantedNodeCapabilityCount);
+  }
+
+  return wakuDnsDiscoveryPromise(enrUrls, wantedNodeCapabilityCount);
+}